Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: mojo/apps/js/bindings/support.cc

Issue 105423003: gin::Wrappable shouldn't inherit from base::RefCounted (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/apps/js/bindings/support.cc
diff --git a/mojo/apps/js/bindings/support.cc b/mojo/apps/js/bindings/support.cc
index e07cc093721956c19ff764db56074458751d0db2..c08fcf625ae993687b14408bf2a55ad13f5b664e 100644
--- a/mojo/apps/js/bindings/support.cc
+++ b/mojo/apps/js/bindings/support.cc
@@ -24,15 +24,15 @@ namespace {
WaitingCallback* AsyncWait(const gin::Arguments& args, mojo::Handle handle,
MojoWaitFlags flags,
v8::Handle<v8::Function> callback) {
- scoped_refptr<WaitingCallback> waiting_callback =
+ gin::Handle<WaitingCallback> waiting_callback =
WaitingCallback::Create(args.isolate(), callback);
BindingsSupport::AsyncWaitID wait_id = BindingsSupport::Get()->AsyncWait(
- handle, flags, waiting_callback.get());
+ handle, flags, waiting_callback.Get());
waiting_callback->set_wait_id(wait_id);
- return waiting_callback.get();
+ return waiting_callback.Get();
}
void CancelWait(WaitingCallback* waiting_callback) {

Powered by Google App Engine
This is Rietveld 408576698