Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

Issue 1054203002: Enable NeedsBraces check and fix some checkstyle issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added if checks Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java b/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
index fc3eb853ebea367c9521731ed2be842582e6c8b9..c27a60f74288dd191dd1ba43228c7840c143e1b4 100644
--- a/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
+++ b/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
@@ -320,9 +320,13 @@ public class ImeAdapter {
private int shouldSendKeyEventWithKeyCode(String text) {
if (text.length() != 1) return COMPOSITION_KEY_CODE;
- if (text.equals("\n")) return KeyEvent.KEYCODE_ENTER;
- else if (text.equals("\t")) return KeyEvent.KEYCODE_TAB;
- else return COMPOSITION_KEY_CODE;
+ if (text.equals("\n")) {
+ return KeyEvent.KEYCODE_ENTER;
+ } else if (text.equals("\t")) {
+ return KeyEvent.KEYCODE_TAB;
+ } else {
+ return COMPOSITION_KEY_CODE;
+ }
}
/**
@@ -365,12 +369,14 @@ public class ImeAdapter {
}
// The content has grown in length: assume the last character is the key that caused it.
- if (newtext.length() > oldtext.length() && newtext.startsWith(oldtext))
+ if (newtext.length() > oldtext.length() && newtext.startsWith(oldtext)) {
return androidKeyEventForCharacter(newtext.charAt(newtext.length() - 1));
+ }
// The content has shrunk in length: assume that backspace was pressed.
- if (oldtext.length() > newtext.length() && oldtext.startsWith(newtext))
+ if (oldtext.length() > newtext.length() && oldtext.startsWith(newtext)) {
return new KeyEvent(KeyEvent.ACTION_DOWN, KeyEvent.KEYCODE_DEL);
+ }
// The content is unchanged or has undergone a complex change (i.e. not a simple tail
// modification) so return an unknown key-code.

Powered by Google App Engine
This is Rietveld 408576698