Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Side by Side Diff: chrome/android/javatests/src/org/chromium/chrome/browser/test/ProviderBookmarksUriTest.java

Issue 1054203002: Enable NeedsBraces check and fix some checkstyle issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.test; 5 package org.chromium.chrome.browser.test;
6 6
7 import android.content.ContentValues; 7 import android.content.ContentValues;
8 import android.database.Cursor; 8 import android.database.Cursor;
9 import android.net.Uri; 9 import android.net.Uri;
10 import android.provider.Browser.BookmarkColumns; 10 import android.provider.Browser.BookmarkColumns;
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
196 196
197 ContentValues values = new ContentValues(); 197 ContentValues values = new ContentValues();
198 values.put(BookmarkColumns.BOOKMARK, isBookmark[1]); 198 values.put(BookmarkColumns.BOOKMARK, isBookmark[1]);
199 values.put(BookmarkColumns.DATE, lastUpdateTime[1]); 199 values.put(BookmarkColumns.DATE, lastUpdateTime[1]);
200 values.put(BookmarkColumns.URL, url[1]); 200 values.put(BookmarkColumns.URL, url[1]);
201 values.putNull(BookmarkColumns.FAVICON); 201 values.putNull(BookmarkColumns.FAVICON);
202 values.put(BookmarkColumns.TITLE, title[1]); 202 values.put(BookmarkColumns.TITLE, title[1]);
203 values.put(BookmarkColumns.VISITS, visits[1]); 203 values.put(BookmarkColumns.VISITS, visits[1]);
204 String[] selectionArgs = { String.valueOf(lastUpdateTime[0]), 204 String[] selectionArgs = { String.valueOf(lastUpdateTime[0]),
205 String.valueOf(isBookmark[0]) }; 205 String.valueOf(isBookmark[0]) };
206 getContentResolver().update(uri, values, BookmarkColumns.FAVICON + " IS NOT NULL AND " + 206 getContentResolver().update(uri, values, BookmarkColumns.FAVICON + " IS NOT NULL AND "
207 BookmarkColumns.DATE + "= ? AND " + BookmarkColumns.BOOKMARK + " = ?", 207 + BookmarkColumns.DATE + "= ? AND " + BookmarkColumns.BOOKMARK + " = ?",
208 selectionArgs); 208 selectionArgs);
209 Cursor cursor = getContentResolver().query(uri, null, null, null, null); 209 Cursor cursor = getContentResolver().query(uri, null, null, null, null);
210 assertEquals(1, cursor.getCount()); 210 assertEquals(1, cursor.getCount());
211 assertTrue(cursor.moveToNext()); 211 assertTrue(cursor.moveToNext());
212 int index = cursor.getColumnIndex(BookmarkColumns.BOOKMARK); 212 int index = cursor.getColumnIndex(BookmarkColumns.BOOKMARK);
213 assertTrue(-1 != index); 213 assertTrue(-1 != index);
214 assertEquals(isBookmark[1], cursor.getInt(index)); 214 assertEquals(isBookmark[1], cursor.getInt(index));
215 index = cursor.getColumnIndex(BookmarkColumns.CREATED); 215 index = cursor.getColumnIndex(BookmarkColumns.CREATED);
216 assertTrue(-1 != index); 216 assertTrue(-1 != index);
217 assertEquals(createdTime[0], cursor.getLong(index)); 217 assertEquals(createdTime[0], cursor.getLong(index));
(...skipping 28 matching lines...) Expand all
246 Uri[] uris = new Uri[2]; 246 Uri[] uris = new Uri[2];
247 byte[][] icons = { BookmarkUtils.getIcon(ICON_PATH), null }; 247 byte[][] icons = { BookmarkUtils.getIcon(ICON_PATH), null };
248 for (int i = 0; i < uris.length; i++) { 248 for (int i = 0; i < uris.length; i++) {
249 uris[i] = addBookmark(url[i], title[i], lastUpdateTime[i], createdTi me[i], visits[i], 249 uris[i] = addBookmark(url[i], title[i], lastUpdateTime[i], createdTi me[i], visits[i],
250 icons[i], isBookmark[i]); 250 icons[i], isBookmark[i]);
251 assertNotNull(uris[i]); 251 assertNotNull(uris[i]);
252 } 252 }
253 253
254 String[] selectionArgs = { String.valueOf(lastUpdateTime[0]), 254 String[] selectionArgs = { String.valueOf(lastUpdateTime[0]),
255 String.valueOf(isBookmark[0]) }; 255 String.valueOf(isBookmark[0]) };
256 getContentResolver().delete(mBookmarksUri, BookmarkColumns.FAVICON + " IS NOT NULL AND " + 256 getContentResolver().delete(mBookmarksUri, BookmarkColumns.FAVICON + " IS NOT NULL AND "
257 BookmarkColumns.DATE + "= ? AND " + BookmarkColumns.BOOKMARK + " = ?", 257 + BookmarkColumns.DATE + "= ? AND " + BookmarkColumns.BOOKMARK + " = ?",
258 selectionArgs); 258 selectionArgs);
259 Cursor cursor = getContentResolver().query(uris[0], null, null, null, nu ll); 259 Cursor cursor = getContentResolver().query(uris[0], null, null, null, nu ll);
260 assertNotNull(cursor); 260 assertNotNull(cursor);
261 assertEquals(0, cursor.getCount()); 261 assertEquals(0, cursor.getCount());
262 cursor = getContentResolver().query(uris[1], null, null, null, null); 262 cursor = getContentResolver().query(uris[1], null, null, null, null);
263 assertNotNull(cursor); 263 assertNotNull(cursor);
264 assertEquals(1, cursor.getCount()); 264 assertEquals(1, cursor.getCount());
265 String[] selectionArgs1 = { String.valueOf(lastUpdateTime[1]), 265 String[] selectionArgs1 = { String.valueOf(lastUpdateTime[1]),
266 String.valueOf(isBookmark[1]) }; 266 String.valueOf(isBookmark[1]) };
267 getContentResolver().delete(mBookmarksUri, BookmarkColumns.FAVICON + " IS NULL AND " + 267 getContentResolver().delete(mBookmarksUri, BookmarkColumns.FAVICON + " IS NULL AND "
268 BookmarkColumns.DATE + "= ? AND " + BookmarkColumns.BOOKMARK + " = ?", 268 + BookmarkColumns.DATE + "= ? AND " + BookmarkColumns.BOOKMARK + " = ?",
269 selectionArgs1); 269 selectionArgs1);
270 cursor = getContentResolver().query(uris[1], null, null, null, null); 270 cursor = getContentResolver().query(uris[1], null, null, null, null);
271 assertNotNull(cursor); 271 assertNotNull(cursor);
272 assertEquals(0, cursor.getCount()); 272 assertEquals(0, cursor.getCount());
273 } 273 }
274 274
275 /* 275 /*
276 * Copied from CTS test with minor adaptations. 276 * Copied from CTS test with minor adaptations.
277 */ 277 */
278 /** 278 /**
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
362 // Test: delete. 362 // Test: delete.
363 getContentResolver().delete(insertUri, null, null); 363 getContentResolver().delete(insertUri, null, null);
364 cursor = getContentResolver().query( 364 cursor = getContentResolver().query(
365 mBookmarksUri, 365 mBookmarksUri,
366 bookmarksProjection, 366 bookmarksProjection,
367 BookmarkColumns._ID + " = " + Id, 367 BookmarkColumns._ID + " = " + Id,
368 null, null); 368 null, null);
369 assertEquals(0, cursor.getCount()); 369 assertEquals(0, cursor.getCount());
370 } 370 }
371 } 371 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698