Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1054113004: Fix crash in ProfileMenuController::validateMenuItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clarify histogram enum naming Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/profiles/profile_menu_controller.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 8bc6e1103e5731a429d23ba6c39dbbbf10f5b410..7d66fb5940e3c51006613bda48381429f2e8b16d 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -30695,6 +30695,31 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</summary>
</histogram>
+<histogram name="Profile.ValidateMenuItemInvalidIndex.IsGuest" enum="Boolean">
+ <owner>anthonyvd@chromium.org</owner>
+ <summary>
+ Whether the active profile is a guest profile when -validateMenuItem in the
+ ProfileMenuController gets an invalid value for the current profile's index.
+ </summary>
+</histogram>
+
+<histogram name="Profile.ValidateMenuItemInvalidIndex.ProfileCount">
+ <owner>anthonyvd@chromium.org</owner>
+ <summary>
+ The count of profiles in the avatar menu when -validateMenuItem in the
+ ProfileMenuController gets an invalid value for the current profile's index.
+ </summary>
+</histogram>
+
+<histogram name="Profile.ValidateMenuItemInvalidIndex.Selector"
+ enum="ValidateMenuItemSelectorType">
+ <owner>anthonyvd@chromium.org</owner>
+ <summary>
+ The selector associated with the menu item when -validateMenuItem in the
+ ProfileMenuController gets an invalid value for the current profile's index.
+ </summary>
+</histogram>
+
<histogram name="Profile.VisitedLinksSize" units="MB">
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<summary>Size of the visited links database.</summary>
@@ -63264,6 +63289,17 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="6" label="CHECKSUM_MISMATCH">Reject due to checksum mismatch</int>
</enum>
+<enum name="ValidateMenuItemSelectorType" type="int">
+ <int value="0"
+ label="The menu items' associated action is an unknown selector."/>
+ <int value="1" label="The menu item's associated action is -newProfile."/>
+ <int value="2" label="The menu item's associated action is -editProfile."/>
+ <int value="3"
+ label="The menu item's associated action is -switchToProfileFromMenu."/>
+ <int value="4"
+ label="The menu item's associated action is -switchToProfileFromDock."/>
+</enum>
+
<enum name="ValidationFailures" type="int">
<int value="0" label="DBus"/>
<int value="1" label="Load Key"/>
« no previous file with comments | « chrome/browser/ui/cocoa/profiles/profile_menu_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698