Chromium Code Reviews Chromium Code Reviews
Issue 1054113004:
Fix crash in ProfileMenuController::validateMenuItem. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 8bc6e1103e5731a429d23ba6c39dbbbf10f5b410..2e794814ee9337e6cd9204f0c3443eb47581c45f 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -30695,6 +30695,31 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </summary> |
| </histogram> |
| +<histogram name="Profile.ValidateMenuItemInvalidIndex.IsGuest" enum="Boolean"> |
| + <owner>anthonyvd@chromium.org</owner> |
| + <summary> |
| + Whether the active profile is a guest profile when validateMenuItem in the |
| + ProfileMenuController gets an invalid value for the current profile's index. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="Profile.ValidateMenuItemInvalidIndex.ProfileCount"> |
| + <owner>anthonyvd@chromium.org</owner> |
| + <summary> |
| + The count of profiles in the avatar menu when validateMenuItem in the |
| + ProfileMenuController gets an invalid value for the current profile's index. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="Profile.ValidateMenuItemInvalidIndex.Selector" |
| + enum="ValidateMenuItemSelectorType"> |
| + <owner>anthonyvd@chromium.org</owner> |
| + <summary> |
| + The selector associated with the menu item when validateMenuItem in the |
|
Alexei Svitkine (slow)
2015/04/23 15:02:54
Nit: For Obj-C methods, the convention is to refer
anthonyvd
2015/04/23 19:04:57
Done.
|
| + ProfileMenuController gets an invalid value for the current profile's index. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="Profile.VisitedLinksSize" units="MB"> |
| <owner>Please list the metric's owners. Add more owner tags as needed.</owner> |
| <summary>Size of the visited links database.</summary> |
| @@ -63264,6 +63289,14 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <int value="6" label="CHECKSUM_MISMATCH">Reject due to checksum mismatch</int> |
| </enum> |
| +<enum name="ValidateMenuItemSelectorType" type="int"> |
| + <int value="0" label="Unknown"/> |
| + <int value="1" label="newProfile"/> |
| + <int value="2" label="editProfile"/> |
| + <int value="3" label="switchToProfileFromMenu"/> |
| + <int value="4" label="switchToProfileFromMenu"/> |
|
Alexei Svitkine (slow)
2015/04/23 15:02:54
Why are these two the same?
Also, these are human
anthonyvd
2015/04/23 19:04:57
Copy-paste error, thanks.
Done.
|
| +</enum> |
| + |
| <enum name="ValidationFailures" type="int"> |
| <int value="0" label="DBus"/> |
| <int value="1" label="Load Key"/> |
