roll skia to 4156

roll skia to 4156
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140580

[reed1, 2012-06-05 14:08:42]

control #2
https://chromiumcodereview.appspot.com/10477011

[reed1, 2012-06-05 14:49:55]

Not sure about these... (brian to investigate)
 
platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.cylinder.html
= TEXT
  platform/chromium/virtual/gpu/fast/canvas/canvas-currentColor.html = TEXT

Rebaseline these
  css3/filters/effect-combined-hw.html = IMAGE
  css3/filters/effect-grayscale-hw.html = IMAGE
  css3/filters/effect-hue-rotate-hw.html = IMAGE
  css3/filters/effect-sepia-hw.html = IMAGE
  platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient.html = IMAGE

[reed1, 2012-06-05 15:02:29]

https://code.google.com/p/chromium/issues/detail?id=131187

[reed1, 2012-06-05 15:15:15]

patch #1 is a full try suite. It showed the need for some
suppressions/rebaselines.

patch #2 only adds those expectations, and just reruns layouttests, to test the
suppressions

[reed1, 2012-06-05 15:59:56]

patch #3 updated to include css3/filters/effect-saturate-hw.html to be
rebaselined.

PTAL

[epoger, 2012-06-05 16:14:12]

Looks pretty good.  But maybe run against the full set of trybots in
http://skia.googlecode.com/svn/trunk/trybots_to_run/layout before landing?

http://codereview.chromium.org/10541005/diff/8004/webkit/tools/layout_tests/t...
File webkit/tools/layout_tests/test_expectations.txt (right):

http://codereview.chromium.org/10541005/diff/8004/webkit/tools/layout_tests/t...
webkit/tools/layout_tests/test_expectations.txt:14: // 2. BEFORE landing your
Chromium CL, land a WebKit CL adding those same
as noted here, you should land a webkit test_expectations change at about the
same time as (preferably before) you land this chromium change.

[reed1, 2012-06-05 19:15:41]

webkit patch is in the queue (I couldn't land manually).

PTAL

[bsalomon, 2012-06-05 19:19:24]

On 2012/06/05 19:15:41, reed1 wrote:
> webkit patch is in the queue (I couldn't land manually).
> 
> PTAL

LGTM