Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 1054073003: Minimal Changes to run tests on iOS (Closed)

Created:
5 years, 8 months ago by stephana
Modified:
5 years, 8 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 5

Patch Set 2 : Addressed comments #

Patch Set 3 : #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -7 lines) Patch
M experimental/iOSSampleApp/Shared/skia_ios.mm View 1 2 chunks +20 lines, -4 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 1 chunk +5 lines, -1 line 0 comments Download
M tests/StreamTest.cpp View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M tools/ProcStats.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
mtklein
nothing to note at the moment... just want to get this searchable in my inbox
5 years, 8 months ago (2015-04-07 14:30:31 UTC) #2
stephana
https://codereview.chromium.org/1054073003/diff/1/dm/DM.cpp File dm/DM.cpp (right): https://codereview.chromium.org/1054073003/diff/1/dm/DM.cpp#newcode614 dm/DM.cpp:614: static const int kSec = 5; This change is ...
5 years, 8 months ago (2015-04-07 18:32:34 UTC) #3
mtklein
Am I still ignoring all scripts? https://codereview.chromium.org/1054073003/diff/1/src/core/SkImageFilter.cpp File src/core/SkImageFilter.cpp (right): https://codereview.chromium.org/1054073003/diff/1/src/core/SkImageFilter.cpp#newcode27 src/core/SkImageFilter.cpp:27: #ifndef SK_BUILD_FOR_IOS How ...
5 years, 8 months ago (2015-04-09 10:16:35 UTC) #4
stephana
PTAL I removed the shell scripts for now to only include the changes necessary to ...
5 years, 8 months ago (2015-04-09 14:28:22 UTC) #5
mtklein
lgtm
5 years, 8 months ago (2015-04-09 14:34:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054073003/60001
5 years, 8 months ago (2015-04-09 14:34:55 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 14:57:57 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/195f62d07d6e996d188b9b2065da073f665a7c5f

Powered by Google App Engine
This is Rietveld 408576698