Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1054073002: Change ozone async swap to fix overlay scheduling (Closed)

Created:
5 years, 8 months ago by achaulk
Modified:
5 years, 8 months ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change ozone async swap to fix overlay scheduling We keep a list of all pending frames insize the GLSurface. Each frame contains a list of overlays. In the future it can contain overlay sync point info too. When ready, we set the ready state and submit all completed frames in order BUG=470185 TEST=link and rockchip Committed: https://crrev.com/77f08ab335da814a065dce6859a674b29e9c1294 Cr-Commit-Position: refs/heads/master@{#324053}

Patch Set 1 #

Total comments: 1

Patch Set 2 : missed a path #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -6 lines) Patch
M ui/gl/gl_surface_ozone.cc View 1 2 7 chunks +68 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
achaulk
5 years, 8 months ago (2015-04-02 17:40:35 UTC) #2
alexst (slow to review)
https://codereview.chromium.org/1054073002/diff/1/ui/gl/gl_surface_ozone.cc File ui/gl/gl_surface_ozone.cc (right): https://codereview.chromium.org/1054073002/diff/1/ui/gl/gl_surface_ozone.cc#newcode212 ui/gl/gl_surface_ozone.cc:212: } I think you are missing: unsubmitted_frames_.back()->ScheduleOverlayPlanes(widget_); unsubmitted_frames_.back()->overlays.clear(); On ...
5 years, 8 months ago (2015-04-02 19:48:53 UTC) #3
achaulk
Ah yes, missed that path
5 years, 8 months ago (2015-04-02 19:53:16 UTC) #4
alexst (slow to review)
lgtm TEST=link and rockchip
5 years, 8 months ago (2015-04-02 20:19:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054073002/20001
5 years, 8 months ago (2015-04-02 20:22:33 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/4277)
5 years, 8 months ago (2015-04-02 21:16:58 UTC) #9
dbehr
Wouldn't it be better to add overlays.clear() to PendingFrame::ScheduleOverlayPlanes() instead of calling it afterwards every ...
5 years, 8 months ago (2015-04-02 21:37:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054073002/40001
5 years, 8 months ago (2015-04-07 15:54:12 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-07 16:22:44 UTC) #15
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 16:23:29 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/77f08ab335da814a065dce6859a674b29e9c1294
Cr-Commit-Position: refs/heads/master@{#324053}

Powered by Google App Engine
This is Rietveld 408576698