build/gyp_chromium - Issue 105403004: Fix handling of GYP defines from supplemental files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/gyp_chromium

Issue 105403004: Fix handling of GYP defines from supplemental files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/gyp_chromium

diff --git a/build/gyp_chromium b/build/gyp_chromium

index 4bc114628b229e8c5544223226a2de358588d93d..077e49b3150162101cffe79602bbfac76562c05d 100755

--- a/build/gyp_chromium

+++ b/build/gyp_chromium

@@ -84,7 +84,8 @@ def GetVarsStringForGN(supplemental_files):

raise

variables = file_data.get('variables')

for v in variables:

- vars_dict[v] = '"' + str(variables[v]) + '"'

+ vars_dict[FormatKeyForGN(v)] = '"' + \

+ str(variables[v]).replace("$", "\\$") + '"'

env_string = os.environ.get('GYP_DEFINES', '')

items = shlex.split(env_string)

« no previous file with comments | « no previous file | no next file » | no next file with comments »