Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3814)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/gyp_chromium

Issue 105403004: Fix handling of GYP defines from supplemental files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/gyp_chromium
diff --git a/build/gyp_chromium b/build/gyp_chromium
index 4bc114628b229e8c5544223226a2de358588d93d..47f1fd6bdb1bb310056b20334efed1a2b91b5b03 100755
--- a/build/gyp_chromium
+++ b/build/gyp_chromium
@@ -84,7 +84,7 @@ def GetVarsStringForGN(supplemental_files):
raise
variables = file_data.get('variables')
for v in variables:
- vars_dict[v] = '"' + str(variables[v]) + '"'
+ vars_dict[FormatKeyForGN(v)] = '"' + str(variables[v]) + '"'
Nico 2013/12/04 22:02:54 Do you need to escape $ here too?
brettw 2013/12/04 22:07:49 Yeah, I guess so!
env_string = os.environ.get('GYP_DEFINES', '')
items = shlex.split(env_string)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698