Issue 105403004: Fix handling of GYP defines from supplemental files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 105403004: Fix handling of GYP defines from supplemental files. (Closed)

Created:
7 years ago by brettw

Modified:
7 years ago

Reviewers:
Nico

CC:
chromium-reviews, trchen

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix handling of GYP defines from supplemental files. This adds a call to the escaping function for variables from supplmental files. R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238792

Patch Set 4 : #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	build/gyp_chromium	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Nico

https://codereview.chromium.org/105403004/diff/20001/build/gyp_chromium File build/gyp_chromium (right): https://codereview.chromium.org/105403004/diff/20001/build/gyp_chromium#newcode87 build/gyp_chromium:87: vars_dict[FormatKeyForGN(v)] = '"' + str(variables[v]) + '"' Do you ...

7 years ago (2013-12-04 22:02:54 UTC) #2

trchen

I'm a gyp noob so I really can't review this. Thank you so much for ...

7 years ago (2013-12-04 22:05:49 UTC) #3

brettw

7 years ago (2013-12-04 22:07:49 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r238792.

Expand Messages | Collapse Messages

Issue 105403004: Fix handling of GYP defines from supplemental files. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Escape $ #

Patch Set 4 : #

Messages