Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Unified Diff: cc/trees/layer_tree_host_impl_unittest.cc

Issue 105393003: Always fall back to root scroll layer for otherwise ignored scrolls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updates Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host_impl_unittest.cc
diff --git a/cc/trees/layer_tree_host_impl_unittest.cc b/cc/trees/layer_tree_host_impl_unittest.cc
index adae669e974dc4c22bf8c5a409fa62a4c2922d0b..eda20fb36975d59594866406e5fdc24ab2fb4321 100644
--- a/cc/trees/layer_tree_host_impl_unittest.cc
+++ b/cc/trees/layer_tree_host_impl_unittest.cc
@@ -1780,7 +1780,7 @@ TEST_F(LayerTreeHostImplTest, ScrollNonScrollableRootWithTopControls) {
host_impl_->active_tree()->FindRootScrollLayer();
DrawFrame();
- EXPECT_EQ(InputHandler::ScrollIgnored,
+ EXPECT_EQ(InputHandler::ScrollStarted,
host_impl_->ScrollBegin(gfx::Point(), InputHandler::Gesture));
host_impl_->top_controls_manager()->ScrollBegin();
@@ -1788,6 +1788,8 @@ TEST_F(LayerTreeHostImplTest, ScrollNonScrollableRootWithTopControls) {
host_impl_->top_controls_manager()->ScrollEnd();
EXPECT_EQ(host_impl_->top_controls_manager()->content_top_offset(), 0.f);
+ host_impl_->ScrollEnd();
+
EXPECT_EQ(InputHandler::ScrollStarted,
host_impl_->ScrollBegin(gfx::Point(),
InputHandler::Gesture));
@@ -2722,7 +2724,6 @@ TEST_F(LayerTreeHostImplTest, OverscrollChildEventBubbling) {
TEST_F(LayerTreeHostImplTest, OverscrollAlways) {
LayerTreeSettings settings;
- settings.always_overscroll = true;
CreateHostImpl(settings, CreateOutputSurface());
SetupScrollAndContentsLayers(gfx::Size(50, 50));

Powered by Google App Engine
This is Rietveld 408576698