Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Unified Diff: sky/framework/embedder.dart

Issue 1053883002: Make embedder.serviceRegistry return a ServiceRegistry instead of ServiceRegistryProxy. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/framework/embedder.dart
diff --git a/sky/framework/embedder.dart b/sky/framework/embedder.dart
index c2c16ef477f8fb161fe0c9862502092bfcf18703..4ebd9f64d78483694999e82d96bb194c71bd9fd1 100644
--- a/sky/framework/embedder.dart
+++ b/sky/framework/embedder.dart
@@ -14,7 +14,7 @@ final _EmbedderImpl embedder = new _EmbedderImpl();
class _EmbedderImpl {
ApplicationConnection _connection;
- ServiceRegistry _serviceRegistry;
tonyg 2015/04/01 22:42:23 Not quite sure how this worked before. Does `mojob
eseidel 2015/04/01 22:43:24 This line was changed earlier today, iirc?
+ ServiceRegistryProxy _serviceRegistry;
final ShellProxy shell = new ShellProxy.fromHandle(
new core.MojoHandle(internals.takeShellProxyHandle()));
@@ -50,11 +50,11 @@ class _EmbedderImpl {
appSp.close();
}
- ServiceRegistryProxy get serviceRegistry {
+ ServiceRegistry get serviceRegistry {
if (_serviceRegistry == null) {
_serviceRegistry = new ServiceRegistryProxy.fromHandle(
new core.MojoHandle(internals.takeServiceRegistry()));
}
- return _serviceRegistry;
+ return _serviceRegistry.ptr;
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698