Make checkdeps.py check third_party/mojo and third_party/mojo_services.

Make checkdeps.py check third_party/mojo and third_party/mojo_services.

BUG=469692
NOPRESUBMIT=true

Committed: https://crrev.com/85bfdcf0c78f57f2dcf1740947993be647d0cc85
Cr-Commit-Position: refs/heads/master@{#323333}

[jam, 2015-04-01 20:54:21]

jam@chromium.org changed reviewers:
+ brettw@chromium.org

[jam, 2015-04-01 20:54:34]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-01 20:54:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1053853002/1

[commit-bot: I haz the power, 2015-04-01 21:04:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-01 21:04:10]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[brettw, 2015-04-01 22:01:35]

lgtm

[jam, 2015-04-01 22:02:13]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2015-04-01 22:03:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1053853002/1

[commit-bot: I haz the power, 2015-04-01 22:06:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-04-01 22:06:59]

Patchset 1 (id:??) landed as
https://crrev.com/85bfdcf0c78f57f2dcf1740947993be647d0cc85
Cr-Commit-Position: refs/heads/master@{#323333}

[Ken Rockot(use gerrit already), 2015-04-02 04:48:53]

rockot@chromium.org changed reviewers:
+ rockot@chromium.org

[Ken Rockot(use gerrit already), 2015-04-02 04:48:53]

Hmm. So this breaks the mojo->chrome roll script we have now 
and makes it fairly annoying to adapt.

Sorry I wasn't thinking clearly when you brought this up earlier, but is this
really necessary? third_party/mojo and third_party/mojo_services should only
ever change during rolls, and header deps are already checked upstream with GN.

[jam, 2015-04-02 14:15:26]

On 2015/04/02 04:48:53, Ken Rockot wrote:
> Hmm. So this breaks the mojo->chrome roll script we have now 
> and makes it fairly annoying to adapt.

Can you expand on why it's hard? is it because the directory is first blown
away?

> 
> Sorry I wasn't thinking clearly when you brought this up earlier, but is this
> really necessary?

we have a problem with code incorrectly using base...

> third_party/mojo and third_party/mojo_services should only
> ever change during rolls, and header deps are already checked upstream with
GN.

upstream doesn't ensure that someone adding a dependency on base gets owners
review from base, so it's not sufficient...

perhaps this would be easier if there was one DEPS file in third_party/mojo and
mojo_services?

[Ken Rockot(use gerrit already), 2015-04-02 15:07:17]

On 2015/04/02 14:15:26, jam wrote:
> On 2015/04/02 04:48:53, Ken Rockot wrote:
> > Hmm. So this breaks the mojo->chrome roll script we have now 
> > and makes it fairly annoying to adapt.
> 
> Can you expand on why it's hard? is it because the directory is first blown
> away?
> 
> > 
> > Sorry I wasn't thinking clearly when you brought this up earlier, but is
this
> > really necessary?
> 
> we have a problem with code incorrectly using base...
> 
> > third_party/mojo and third_party/mojo_services should only
> > ever change during rolls, and header deps are already checked upstream with
> GN.
> 
> upstream doesn't ensure that someone adding a dependency on base gets owners
> review from base, so it's not sufficient...
> 
> perhaps this would be easier if there was one DEPS file in third_party/mojo
and
> mojo_services?

Ah right. OK. I'm going to roll mojo. I'll consolidate DEPS in the process and
include you on the review. Thanks!