Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1053833002: Revert of [DevTools] Unpause renderer when paused RenderFrame is closed. (Closed)

Created:
5 years, 8 months ago by mfomitchev1
Modified:
5 years, 8 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, yurys, darin-cc_chromium.org, devtools-reviews_chromium.org, mkwst+moarreviews-renderer_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [DevTools] Unpause renderer when paused RenderFrame is closed. (patchset #4 id:60001 of https://codereview.chromium.org/1047653003/) Reason for revert: Broke Linux ASan LSan Tests (1): https://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/12190/steps/content_browsertests/logs/DevToolsAgentTest.DevToolsResumeOnClose Original issue's description: > [DevTools] Unpause renderer when paused RenderFrame is closed. > > BUG=469421 > > Committed: https://crrev.com/cf00f40f5d627de9b6110682235ebb3dfac60486 > Cr-Commit-Position: refs/heads/master@{#323258} TBR=creis@chromium.org,kenrb@chromium.org,nasko@chromium.org,pfeldman@chromium.org,dgozman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=469421 Committed: https://crrev.com/b58e7736a6083431e39f86262ce441fe47d907d1 Cr-Commit-Position: refs/heads/master@{#323315}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -80 lines) Patch
M content/public/renderer/render_frame_observer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/devtools/devtools_agent.h View 4 chunks +2 lines, -8 lines 0 comments Download
M content/renderer/devtools/devtools_agent.cc View 4 chunks +3 lines, -8 lines 0 comments Download
M content/renderer/render_frame_impl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 3 chunks +0 lines, -47 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_widget.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_widget.cc View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mfomitchev1
Created Revert of [DevTools] Unpause renderer when paused RenderFrame is closed.
5 years, 8 months ago (2015-04-01 20:20:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1053833002/1
5 years, 8 months ago (2015-04-01 20:21:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-01 20:22:24 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 20:23:08 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b58e7736a6083431e39f86262ce441fe47d907d1
Cr-Commit-Position: refs/heads/master@{#323315}

Powered by Google App Engine
This is Rietveld 408576698