Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1053773003: Revert of Fix for menus blocking user activity detection (Retry 2). (Closed)

Created:
5 years, 8 months ago by spang
Modified:
5 years, 8 months ago
CC:
chromium-reviews, ozone-reviews_chromium.org, kalyank, sadrul, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix for menus blocking user activity detection (Retry 2). (patchset #1 id:1 of https://codereview.chromium.org/1024583003/) Reason for revert: Breaks multiple clicking on 2nd display Original issue's description: > Fix for menus blocking user activity detection (Retry 2). > > Original CL reverted here: https://codereview.chromium.org/1013003002/ > > Nothing has changed from that CL above. We are relanding after Oshima > prevented marking events created from the same native event as "repeat" > in this CL https://codereview.chromium.org/1017323002/ > > Menus used to block detecting user activity. The fix works by making the > UserActivityDetector a PlatformEventObserver rather than an > EventHandler. > Also made sure that PlatformEventSource has an instance in > ozone_platform_test.cc > > TBR=sadrul@chromium.org,spang@chromium.org,oshima@chromium.org,jamescook@chromium.org > BUG=462735 > TEST=ui_base_unittests --gtest_filter=UserActivityDetectorTest.* > > Committed: https://crrev.com/dbfa9102e7c6dfa13439ef1502d4baa9c3a31f31 > Cr-Commit-Position: refs/heads/master@{#321426} TBR=jamescook@chromium.org,oshima@chromium.org,sadrul@chromium.org,afakhry@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=462735, 472222 Committed: https://crrev.com/a5784b85fe478bc4fd9ebc09514878154019fa79 Cr-Commit-Position: refs/heads/master@{#323394}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -90 lines) Patch
M ash/shell.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M extensions/shell/browser/shell_desktop_controller_aura.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/base/user_activity/user_activity_detector.h View 2 chunks +8 lines, -11 lines 0 comments Download
M ui/base/user_activity/user_activity_detector.cc View 3 chunks +25 lines, -36 lines 0 comments Download
M ui/base/user_activity/user_activity_detector_unittest.cc View 14 chunks +13 lines, -31 lines 0 comments Download
M ui/ozone/platform/test/ozone_platform_test.cc View 2 chunks +1 line, -12 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
spang
Created Revert of Fix for menus blocking user activity detection (Retry 2).
5 years, 8 months ago (2015-04-02 01:31:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1053773003/1
5 years, 8 months ago (2015-04-02 01:32:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-02 01:34:29 UTC) #4
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:21:05 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5784b85fe478bc4fd9ebc09514878154019fa79
Cr-Commit-Position: refs/heads/master@{#323394}

Powered by Google App Engine
This is Rietveld 408576698