Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1053773002: Add WebScopedAXContext to allow a one-time snapshot of accessibility. (Closed)

Created:
5 years, 8 months ago by dmazzoni
Modified:
5 years, 8 months ago
Reviewers:
dglazkov
CC:
aboxhall, blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, dmazzoni, eae+blinkwatch, je_julie(Not used), nektarios, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add WebScopedAXContext to allow a one-time snapshot of accessibility. This makes it possible to query the accessibility tree without enabling it globally. BUG=472704 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193492

Patch Set 1 #

Patch Set 2 : Fix #

Patch Set 3 : Update other callers of ScopedAXObjectCache to use RefPtr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -8 lines) Patch
M Source/core/dom/AXObjectCache.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.cpp View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/accessibility/InspectorAccessibilityAgent.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebAXObject.cpp View 1 2 3 chunks +16 lines, -1 line 0 comments Download
M public/web/WebAXObject.h View 1 2 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
dmazzoni
5 years, 8 months ago (2015-04-02 17:48:33 UTC) #2
dglazkov
lgtm
5 years, 8 months ago (2015-04-02 17:58:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1053773002/20001
5 years, 8 months ago (2015-04-02 18:03:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/55703)
5 years, 8 months ago (2015-04-02 21:12:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1053773002/40001
5 years, 8 months ago (2015-04-09 19:20:59 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 23:43:25 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193492

Powered by Google App Engine
This is Rietveld 408576698