Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 10537183: Upwards compatibility for Win8 SDK IDataObjectAsyncCapability/IAsyncOperation (Closed)

Created:
8 years, 6 months ago by scottmg
Modified:
8 years, 6 months ago
CC:
chromium-reviews, dcheng
Visibility:
Public.

Description

Upwards compatibility for Win8 SDK IDataObjectAsyncCapability/IAsyncOperation The Windows 8 SDK renames this interface (WAT) and documents this new name as being binary-compatible. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142472

Patch Set 1 #

Patch Set 2 : iid as well #

Total comments: 2

Patch Set 3 : shorten url #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M ui/base/dragdrop/os_exchange_data_provider_win.h View 1 2 5 chunks +14 lines, -4 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_win.cc View 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
8 years, 6 months ago (2012-06-15 03:14:47 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm http://codereview.chromium.org/10537183/diff/2001/ui/base/dragdrop/os_exchange_data_provider_win.h File ui/base/dragdrop/os_exchange_data_provider_win.h (right): http://codereview.chromium.org/10537183/diff/2001/ui/base/dragdrop/os_exchange_data_provider_win.h#newcode14 ui/base/dragdrop/os_exchange_data_provider_win.h:14: // http://msdn.microsoft.com/en-us/library/windows/desktop/bb776309(v=vs.85).aspx url shortener pls.
8 years, 6 months ago (2012-06-15 18:26:47 UTC) #2
scottmg
+ben for OWNERS http://codereview.chromium.org/10537183/diff/2001/ui/base/dragdrop/os_exchange_data_provider_win.h File ui/base/dragdrop/os_exchange_data_provider_win.h (right): http://codereview.chromium.org/10537183/diff/2001/ui/base/dragdrop/os_exchange_data_provider_win.h#newcode14 ui/base/dragdrop/os_exchange_data_provider_win.h:14: // http://msdn.microsoft.com/en-us/library/windows/desktop/bb776309(v=vs.85).aspx On 2012/06/15 18:26:47, cpu ...
8 years, 6 months ago (2012-06-15 19:16:38 UTC) #3
Ben Goodger (Google)
lgtm
8 years, 6 months ago (2012-06-15 19:17:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10537183/7001
8 years, 6 months ago (2012-06-15 19:18:35 UTC) #5
commit-bot: I haz the power
8 years, 6 months ago (2012-06-15 20:45:01 UTC) #6
Change committed as 142472

Powered by Google App Engine
This is Rietveld 408576698