Issue 10537122: Fix analysis server caching edge case http://code.google.com/p/dart/issues/detail?id=3423

Issue 10537122: Fix analysis server caching edge case http://code.google.com/p/dart/issues/detail?id=3423 (Closed)

Created:
8 years, 6 months ago by danrubel

Modified:
8 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix analysis server caching edge case http://code.google.com/p/dart/issues/detail?id=3423 Committed: https://code.google.com/p/dart/source/detail?r=8650

Patch Set 4 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+573 lines, -201 lines)			Patch
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisServer.java	View	1 2 3	5 chunks	+45 lines, -62 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/CacheReader.java	View		1 chunk	+156 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/CacheWriter.java	View		1 chunk	+94 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/Context.java	View		3 chunks	+5 lines, -7 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/Library.java	View		5 chunks	+12 lines, -77 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/AnalysisServerTest.java	View	1 2	8 chunks	+89 lines, -55 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/CacheTest.java	View	1	1 chunk	+171 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/TestAll.java	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM http://codereview.chromium.org/10537122/diff/1/editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/AnalysisServerTest.java File editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/AnalysisServerTest.java (right): http://codereview.chromium.org/10537122/diff/1/editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/AnalysisServerTest.java#newcode686 editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/AnalysisServerTest.java:686: FileUtilities.setContents(cacheFile, ""); It would be really good to ...

8 years, 6 months ago (2012-06-12 16:12:11 UTC) #2

danrubel

http://codereview.chromium.org/10537122/diff/1/editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/AnalysisServerTest.java File editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/AnalysisServerTest.java (right): http://codereview.chromium.org/10537122/diff/1/editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/AnalysisServerTest.java#newcode686 editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/AnalysisServerTest.java:686: FileUtilities.setContents(cacheFile, ""); On 2012/06/12 16:12:11, Brian Wilkerson wrote: > ...

8 years, 6 months ago (2012-06-13 13:39:30 UTC) #3

LGTM

Expand Messages | Collapse Messages