Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1053663003: Cleanup: Remove unused variables in chrome/ found by Scythe. (Closed)

Created:
5 years, 8 months ago by Lei Zhang
Modified:
5 years, 8 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, dbeam+watch-options_chromium.org, skanuj+watch_chromium.org, sadrul, nkostylev+watch_chromium.org, zea+watch_chromium.org, tzik, dhollowa+watch_chromium.org, dougw+watch_chromium.org, maxbogue+watch_chromium.org, browser-components-watch_chromium.org, dcheng, rginda+watch_chromium.org, markusheintz_, aandrey+blink_chromium.org, stevenjb+watch_chromium.org, tim+watch_chromium.org, tapted, cbentzel+watch_chromium.org, melevin+watch_chromium.org, Matt Giuca, grt+watch_chromium.org, dzhioev+watch_chromium.org, pvalenzuela+watch_chromium.org, rouslan+autofillwatch_chromium.org, devtools-reviews_chromium.org, kalyank, pedrosimonetti+watch_chromium.org, dbeam+watch-ntp_chromium.org, jennb, extensions-reviews_chromium.org, wjmaclean, nhiroki, jfweitz+watch_chromium.org, pam+watch_chromium.org, jianli, oshima+watch_chromium.org, estade+watch_chromium.org, Jered, maniscalco+watch_chromium.org, chromium-apps-reviews_chromium.org, michaelpg+watch-options_chromium.org, tfarina, donnd+watch_chromium.org, Dmitry Titov, yurys, plaree+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, James Su, kinuko+fileapi, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove unused variables in chrome/ found by Scythe. Committed: https://crrev.com/397accd46320292657b9ca5eea6c1a81a38ef004 Cr-Commit-Position: refs/heads/master@{#323854}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -236 lines) Patch
M chrome/browser/autocomplete/shortcuts_database.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/autofill/content_autofill_driver_browsertest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/captive_portal/captive_portal_tab_helper.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/captive_portal/captive_portal_tab_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/defaults.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/defaults.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M chrome/browser/devtools/browser_list_tabcontents_provider.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/devtools/browser_list_tabcontents_provider.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/devtools/device/port_forwarding_controller.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/devtools/device/port_forwarding_controller.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/devtools/devtools_network_transaction.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/devtools/remote_debugging_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/feedback/show_feedback_page.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/first_run/first_run_internal.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/history/history_unittest.cc View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/local_discovery/privet_url_fetcher.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/prefs/tracked/pref_hash_filter_unittest.cc View 3 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/browser_features.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/browser_features.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search/most_visited_iframe_source.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/search/most_visited_iframe_source.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/service_process/service_process_control.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/service_process/service_process_control.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/sessions/session_restore.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/speech/tts_message_filter.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/speech/tts_message_filter.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_constants.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_constants.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_constants.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/mock_remote_file_sync_service.h View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/mock_remote_file_sync_service.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search/suggestions/suggestions_search_provider_unittest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/app_list/speech_auth_helper.h View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/app_list/speech_auth_helper.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/exclusive_access/fullscreen_controller_state_test.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_constants.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/search/instant_page.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/search/instant_page.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/search/instant_page_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/search/instant_tab.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/inline_login_dialog.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/sync/inline_login_dialog.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_sync_starter.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/crypto_module_password_dialog_view_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/first_run_bubble_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/link_disambiguation/link_disambiguation_popup.cc View 5 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/website_settings/permissions_bubble_view.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/base_screen_handler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/interstitials/interstitial_ui.cc View 4 chunks +4 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/ntp/thumbnail_source.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/ntp/thumbnail_source.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/options_ui.cc View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/ui/webui/options/sync_setup_handler.h View 3 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/ui/webui/options/sync_setup_handler.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/policy_ui.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/zoom/zoom_controller_browsertest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_render_process_observer.h View 3 chunks +1 line, -6 lines 0 comments Download
M chrome/renderer/chrome_render_process_observer.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/renderer/extensions/app_bindings.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/extensions/chrome_v8_extension_handler.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/renderer/extensions/chrome_v8_extension_handler.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/webstore_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_url_fetcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/service/cloud_print/printer_job_handler.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/service/cloud_print/printer_job_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/utility/image_writer/error_messages.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/utility/image_writer/error_messages.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Lei Zhang
5 years, 8 months ago (2015-04-03 23:55:43 UTC) #4
James Hawkins
lgtm
5 years, 8 months ago (2015-04-03 23:56:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1053663003/40001
5 years, 8 months ago (2015-04-03 23:57:46 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 8 months ago (2015-04-04 00:03:15 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-04 00:04:13 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/397accd46320292657b9ca5eea6c1a81a38ef004
Cr-Commit-Position: refs/heads/master@{#323854}

Powered by Google App Engine
This is Rietveld 408576698