Gallery: Support RAW files in Gallery.

Gallery: Support RAW files in Gallery.

 * Show RAW images.
 * Edit and save as JPG file.

BUG=396702
TEST=GalleryJsTest.GalleryItemTest

Committed: https://crrev.com/a122864577433c44df8f0cb4cb0fb162a6e7d643
Cr-Commit-Position: refs/heads/master@{#323464}

[hirono, 2015-04-01 15:25:25]

hirono@chromium.org changed reviewers:
+ yawano@chromium.org

[hirono, 2015-04-01 15:25:26]

PTAL, thanks!

[yawano, 2015-04-02 05:56:35]

https://codereview.chromium.org/1053653003/diff/1/ui/file_manager/gallery/js/...
File ui/file_manager/gallery/js/image_editor/image_util.js (right):

https://codereview.chromium.org/1053653003/diff/1/ui/file_manager/gallery/js/...
ui/file_manager/gallery/js/image_editor/image_util.js:531: if (this.image_.src
=== url)
Why do you do this check here? Does it become to happen that same image is
loaded twice?

https://codereview.chromium.org/1053653003/diff/1/ui/file_manager/gallery/js/...
ui/file_manager/gallery/js/image_editor/image_util.js:542:
loadImage(result.data);
What happens if ImageLoaderClient fails to load an image? Isn't it necessary to
do error handling here?

https://codereview.chromium.org/1053653003/diff/1/ui/file_manager/gallery/js/...
File ui/file_manager/gallery/js/slide_mode.js (right):

https://codereview.chromium.org/1053653003/diff/1/ui/file_manager/gallery/js/...
ui/file_manager/gallery/js/slide_mode.js:1048: var times =
values[SlideMode.OVERWRITE_BUBBLE_KEY] || 0;
nit: When you specify default value at line:1044, || 0 is not necessary.

[hirono, 2015-04-02 07:55:47]

Thanks!

https://codereview.chromium.org/1053653003/diff/1/ui/file_manager/gallery/js/...
File ui/file_manager/gallery/js/image_editor/image_util.js (right):

https://codereview.chromium.org/1053653003/diff/1/ui/file_manager/gallery/js/...
ui/file_manager/gallery/js/image_editor/image_util.js:531: if (this.image_.src
=== url)
On 2015/04/02 05:56:34, yawano wrote:
> Why do you do this check here? Does it become to happen that same image is
> loaded twice?

There are two possible case.

 * Currently SlideMode class has a bug which calls prefetch() method twice. I
have a fix. Let me send it in separated patch.
 * If two RAW files have same thumbnail JPG, the data URLs are equaled.

Also I found out race bug around ImageUtil.
Previously resetImage_ method is asynchronous so we may do

* request A, resetImage_ A
* request B, resetImage_ B
* resetImage_ A complete, start to load A
* resetImage_ B complete, start to load B (image has 'src' attribute of A)

Fixed the bug in the latest patch.

https://codereview.chromium.org/1053653003/diff/1/ui/file_manager/gallery/js/...
ui/file_manager/gallery/js/image_editor/image_util.js:542:
loadImage(result.data);
On 2015/04/02 05:56:34, yawano wrote:
> What happens if ImageLoaderClient fails to load an image? Isn't it necessary
to
> do error handling here?

Done.

https://codereview.chromium.org/1053653003/diff/1/ui/file_manager/gallery/js/...
File ui/file_manager/gallery/js/slide_mode.js (right):

https://codereview.chromium.org/1053653003/diff/1/ui/file_manager/gallery/js/...
ui/file_manager/gallery/js/slide_mode.js:1048: var times =
values[SlideMode.OVERWRITE_BUBBLE_KEY] || 0;
On 2015/04/02 05:56:34, yawano wrote:
> nit: When you specify default value at line:1044, || 0 is not necessary.

Done.

[yawano, 2015-04-02 10:01:52]

https://codereview.chromium.org/1053653003/diff/40001/ui/file_manager/gallery...
File ui/file_manager/gallery/js/image_editor/image_util.js (right):

https://codereview.chromium.org/1053653003/diff/40001/ui/file_manager/gallery...
ui/file_manager/gallery/js/image_editor/image_util.js:533: targetImage.onerror =
onError.bind(this, 'GALLERY_IMAGE_ERROR');
onError is already bound in line 513.

[hirono, 2015-04-02 10:39:06]

https://codereview.chromium.org/1053653003/diff/40001/ui/file_manager/gallery...
File ui/file_manager/gallery/js/image_editor/image_util.js (right):

https://codereview.chromium.org/1053653003/diff/40001/ui/file_manager/gallery...
ui/file_manager/gallery/js/image_editor/image_util.js:533: targetImage.onerror =
onError.bind(this, 'GALLERY_IMAGE_ERROR');
On 2015/04/02 10:01:52, yawano wrote:
> onError is already bound in line 513.

Done.

[yawano, 2015-04-02 10:39:54]

lgtm. Thank you!

[hirono, 2015-04-02 11:18:01]

The CQ bit was checked by hirono@chromium.org

[hirono, 2015-04-02 11:18:09]

Thanks!

[commit-bot: I haz the power, 2015-04-02 11:18:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1053653003/60001

[commit-bot: I haz the power, 2015-04-02 11:22:32]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-03 20:24:25]

Patchset 4 (id:??) landed as
https://crrev.com/a122864577433c44df8f0cb4cb0fb162a6e7d643
Cr-Commit-Position: refs/heads/master@{#323464}