Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1053623004: Drive: Add multipart related utility methods. (Closed)

Created:
5 years, 8 months ago by hirono
Modified:
5 years, 8 months ago
Reviewers:
yoshiki
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drive: Add multipart related utility methods. The CL extracts existing code as utility methods so that they can be used by newly added BatchRequest class. BUG=451917 TEST=None Committed: https://crrev.com/435892ffa94234faaab2f49118c0a392eb61f801 Cr-Commit-Position: refs/heads/master@{#323892}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -40 lines) Patch
M google_apis/drive/base_requests.h View 2 chunks +20 lines, -0 lines 0 comments Download
M google_apis/drive/base_requests.cc View 6 chunks +77 lines, -40 lines 0 comments Download
M google_apis/drive/drive_api_error_codes.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M google_apis/drive/drive_api_error_codes.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
hirono
PTAL, thanks!
5 years, 8 months ago (2015-04-03 09:13:23 UTC) #2
yoshiki
lgtm.
5 years, 8 months ago (2015-04-03 13:28:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1053623004/20001
5 years, 8 months ago (2015-04-06 03:36:10 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-06 04:50:38 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 04:51:21 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/435892ffa94234faaab2f49118c0a392eb61f801
Cr-Commit-Position: refs/heads/master@{#323892}

Powered by Google App Engine
This is Rietveld 408576698