Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1053583005: [turbofan] Reduce duplication between ControlReducer::ReduceIf(True,False). (Closed)

Created:
5 years, 8 months ago by titzer
Modified:
5 years, 8 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Reduce duplication between ControlReducer::ReduceIf(True,False). R=svenpanne@chromium.org BUG= Committed: https://crrev.com/cdeaf08a0ddf31e27cb9f57bf22dd878ec0625d2 Cr-Commit-Position: refs/heads/master@{#27582}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -22 lines) Patch
M src/compiler/control-reducer.cc View 1 3 chunks +8 lines, -22 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
titzer
5 years, 8 months ago (2015-04-02 09:05:10 UTC) #1
Sven Panne
LGTM with a tiny nit. https://codereview.chromium.org/1053583005/diff/1/src/compiler/control-reducer.cc File src/compiler/control-reducer.cc (right): https://codereview.chromium.org/1053583005/diff/1/src/compiler/control-reducer.cc#newcode585 src/compiler/control-reducer.cc:585: // fold a true ...
5 years, 8 months ago (2015-04-02 09:34:05 UTC) #2
titzer
On 2015/04/02 09:34:05, Sven Panne wrote: > LGTM with a tiny nit. > > https://codereview.chromium.org/1053583005/diff/1/src/compiler/control-reducer.cc ...
5 years, 8 months ago (2015-04-02 09:37:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1053583005/20001
5 years, 8 months ago (2015-04-02 09:38:35 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-02 10:03:19 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-02 10:03:37 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cdeaf08a0ddf31e27cb9f57bf22dd878ec0625d2
Cr-Commit-Position: refs/heads/master@{#27582}

Powered by Google App Engine
This is Rietveld 408576698