Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 1053563004: Add src/extensions to All target in gyp (Closed)

Created:
5 years, 8 months ago by tapted
Modified:
5 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add src/extensions to All target in gyp Use the same condition as chromium_builder_tests. The targets are already in all_gn, and run on the trybots via the chromium_builder_tests target. Putting them in All just helps developers spot compile errors locally, before they're caught by the bots. Committed: https://crrev.com/f42e70932de69422378f3fef25df8afc4f2bb8e1 Cr-Commit-Position: refs/heads/master@{#324739}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/all.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tapted
Hi Dirk, please take a look
5 years, 8 months ago (2015-04-10 09:07:47 UTC) #2
Dirk Pranke
lgtm
5 years, 8 months ago (2015-04-10 17:01:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1053563004/1
5 years, 8 months ago (2015-04-11 01:04:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-11 01:19:35 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-11 01:20:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f42e70932de69422378f3fef25df8afc4f2bb8e1
Cr-Commit-Position: refs/heads/master@{#324739}

Powered by Google App Engine
This is Rietveld 408576698