Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: src/generator.js

Issue 1053563002: Revert of Correctly compute line numbers in functions from the function constructor. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Added regression test Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/cpu-profiler.cc ('k') | src/messages.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/generator.js
diff --git a/src/generator.js b/src/generator.js
index 9ab7dcb9aab9b78baea82ca749ce129a5350be75..fa6e9764ad1865b6c7e23dc7054ec4cc11ccf431 100644
--- a/src/generator.js
+++ b/src/generator.js
@@ -74,7 +74,13 @@ function GeneratorFunctionPrototypeConstructor(x) {
}
function GeneratorFunctionConstructor(arg1) { // length == 1
- return NewFunctionFromString(arguments, 'function*');
+ var source = NewFunctionString(arguments, 'function*');
+ var global_proxy = %GlobalProxy(global);
+ // Compile the string in the constructor and not a helper so that errors
+ // appear to come from here.
+ var f = %_CallFunction(global_proxy, %CompileString(source, true));
+ %FunctionMarkNameShouldPrintAsAnonymous(f);
+ return f;
}
« no previous file with comments | « src/cpu-profiler.cc ('k') | src/messages.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698