Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 1053563002: Revert of Correctly compute line numbers in functions from the function constructor. (Closed)

Created:
5 years, 8 months ago by kozy
Modified:
5 years, 8 months ago
CC:
v8-dev
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Correctly compute line numbers in functions from the function constructor. (patchset #5 id:80001 of https://codereview.chromium.org/701093003/) Reason for revert: Locations from New Function are broken in DevTools. Original issue's description: > Correctly compute line numbers in functions from the function constructor. > > R=aandrey@chromium.org > BUG=chromium:109362 > LOG=Y > > Committed: https://code.google.com/p/v8/source/detail?r=25289 TBR=aandrey@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:109362 LOG=Y Committed: https://crrev.com/66d5519f7eef61ee892714254d878bf0fe2619f0 Cr-Commit-Position: refs/heads/master@{#27564}

Patch Set 1 #

Patch Set 2 : Added regression test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -64 lines) Patch
M src/cpu-profiler.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/generator.js View 1 1 chunk +7 lines, -1 line 0 comments Download
M src/messages.js View 1 1 chunk +22 lines, -14 lines 0 comments Download
M src/objects.cc View 1 1 chunk +14 lines, -18 lines 0 comments Download
M src/runtime/runtime.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-compiler.cc View 1 2 chunks +1 line, -10 lines 0 comments Download
M src/v8natives.js View 1 3 chunks +11 lines, -10 lines 0 comments Download
M test/message/single-function-literal.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-109362.js View 1 2 chunks +39 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
kozy
Created Revert of Correctly compute line numbers in functions from the function constructor.
5 years, 8 months ago (2015-04-01 04:54:33 UTC) #1
kozy
Yang, please take a look. I am adding regression blink layout test today.
5 years, 8 months ago (2015-04-01 04:57:43 UTC) #2
Yang
On 2015/04/01 04:57:43, kozyatinskiy wrote: > Yang, please take a look. I am adding regression ...
5 years, 8 months ago (2015-04-01 06:22:50 UTC) #3
kozy
On 2015/04/01 06:22:50, Yang wrote: > On 2015/04/01 04:57:43, kozyatinskiy wrote: > > Yang, please ...
5 years, 8 months ago (2015-04-01 10:10:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1053563002/230001
5 years, 8 months ago (2015-04-01 10:11:08 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:230001)
5 years, 8 months ago (2015-04-01 10:11:19 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/66d5519f7eef61ee892714254d878bf0fe2619f0 Cr-Commit-Position: refs/heads/master@{#27564}
5 years, 8 months ago (2015-04-01 10:11:35 UTC) #9
Michael Achenbach
Please land a blink-side expectation change (i.e. needsmanualrebaseline) asap for the breaking layout tests.
5 years, 8 months ago (2015-04-01 12:56:25 UTC) #11
kozy
On 2015/04/01 12:56:25, Michael Achenbach (travelling) wrote: > Please land a blink-side expectation change (i.e. ...
5 years, 8 months ago (2015-04-01 13:09:30 UTC) #12
Michael Achenbach
On 2015/04/01 13:09:30, kozyatinskiy wrote: > On 2015/04/01 12:56:25, Michael Achenbach (travelling) wrote: > > ...
5 years, 8 months ago (2015-04-01 14:08:15 UTC) #13
Michael Achenbach
5 years, 8 months ago (2015-04-01 14:09:07 UTC) #14
Message was sent while issue was closed.
The bots are on http://build.chromium.org/p/client.v8/console in the Layout
category.

Powered by Google App Engine
This is Rietveld 408576698