Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10535148: Fix for issue 1781 (Closed)

Created:
8 years, 6 months ago by Brian Wilkerson
Modified:
8 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java View 2 chunks +1 line, -2 lines 2 comments Download
M compiler/javatests/com/google/dart/compiler/resolver/CompileTimeConstantTest.java View 1 chunk +2 lines, -1 line 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Brian Wilkerson
8 years, 6 months ago (2012-06-13 15:44:07 UTC) #1
scheglov
http://codereview.chromium.org/10535148/diff/1/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java File compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java (left): http://codereview.chromium.org/10535148/diff/1/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java#oldcode204 compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java:204: case BIT_NOT: Why this line was removed?
8 years, 6 months ago (2012-06-13 15:49:12 UTC) #2
Brian Wilkerson
http://codereview.chromium.org/10535148/diff/1/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java File compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java (left): http://codereview.chromium.org/10535148/diff/1/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java#oldcode204 compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java:204: case BIT_NOT: > Why this line was removed? Because ...
8 years, 6 months ago (2012-06-13 15:51:30 UTC) #3
scheglov
8 years, 6 months ago (2012-06-13 15:59:29 UTC) #4 
LGTM

Powered by Google App Engine
This is Rietveld 408576698