Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 1053493005: Default iOS builds to our code signing identity. (Closed)

Created:
5 years, 8 months ago by mtklein_C
Modified:
5 years, 8 months ago
Reviewers:
mtklein, caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Default iOS builds to our code signing identity. It's super tedious to keep setting it every time I rerun ./gyp_skia. Doesn't look like it'll bother the bots. BUG=skia: Committed: https://skia.googlesource.com/skia/+/ea6075e3ea92d6fa0970f89f7532c55eb140a9b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gyp/common_conditions.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
mtklein_C
5 years, 8 months ago (2015-04-16 18:59:57 UTC) #2
caryclark
lgtm
5 years, 8 months ago (2015-04-16 19:55:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1053493005/1
5 years, 8 months ago (2015-04-16 19:55:59 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 20:30:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ea6075e3ea92d6fa0970f89f7532c55eb140a9b3

Powered by Google App Engine
This is Rietveld 408576698