Issue 1053493003: Make mojo/application:test_support a group target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1053493003: Make mojo/application:test_support a group target. (Closed)

Created:
5 years, 8 months ago by msw

Modified:
5 years, 8 months ago

Reviewers:
sky

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Make mojo/application:test_support a group target. The [data_]deps of source_set dependencies aren't built. The group target type works as I'd expect; see bug for details. This is still a GN bug(?) workaround, but a cleaner one. BUG=477104 TEST=Building mojo/services/html_viewer:apptest builds mojo_shell R=sky@chromium.org Committed: https://crrev.com/b88873e437fd81320bc7149908eee71561726a4a Cr-Commit-Position: refs/heads/master@{#325482}

Patch Set 1 #

Patch Set 2 : Wrap the source_set in a group target. #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -20 lines)			Patch
M	mojo/application/BUILD.gn	View	1	2 chunks	+10 lines, -2 lines	0 comments	Download
M	mojo/services/html_viewer/BUILD.gn	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	mojo/services/network/BUILD.gn	View		1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1053493003/20001

5 years, 8 months ago (2015-04-16 18:07:43 UTC) #4

commit-bot: I haz the power

5 years, 8 months ago (2015-04-16 18:40:08 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/b88873e437fd81320bc7149908eee71561726a4a
Cr-Commit-Position: refs/heads/master@{#325482}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages