tools/telemetry/telemetry/unittest_util/system_stub.py - Issue 1053423002: Update cloud_storage_stub to handle buckets other than the 3 telemetry defaults.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/unittest_util/system_stub.py

Issue 1053423002: Update cloud_storage_stub to handle buckets other than the 3 telemetry defaults. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/unittest_util/system_stub.py

diff --git a/tools/telemetry/telemetry/unittest_util/system_stub.py b/tools/telemetry/telemetry/unittest_util/system_stub.py

index e0073ca22b9560df6a63c45cd28a04715f67518f..74bd8e8f499437a70f8489d0be1691fb02183413 100644

--- a/tools/telemetry/telemetry/unittest_util/system_stub.py

+++ b/tools/telemetry/telemetry/unittest_util/system_stub.py

@@ -205,7 +205,7 @@ class CloudStorageModuleStub(object):

elif bucket == CloudStorageModuleStub.INTERNAL_BUCKET:

if self.permission_level < CloudStorageModuleStub.INTERNAL_PERMISSION:

raise CloudStorageModuleStub.PermissionError()

- else:

+ elif bucket not in self.remote_paths:

raise CloudStorageModuleStub.NotFoundError()

def SetRemotePathsForTesting(self, remote_path_dict=None):

« no previous file with comments | « no previous file | no next file » | no next file with comments »