Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1053323003: Change name of generic Media Router icon file. (Closed)

Created:
5 years, 8 months ago by apacible
Modified:
5 years, 8 months ago
Reviewers:
oshima
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change name of generic Media Router icon file. This makes the naming convention uniform with the other Media Router icons. BUG=464222 Committed: https://crrev.com/08cef1e936221c0a33c8beef9c0843596e3de3dd Cr-Commit-Position: refs/heads/master@{#324069}

Patch Set 1 : #

Total comments: 2

Messages

Total messages: 9 (3 generated)
apacible
PTAL, thanks!
5 years, 8 months ago (2015-04-07 01:05:44 UTC) #3
oshima
lgtm https://codereview.chromium.org/1053323003/diff/20001/chrome/app/theme/theme_resources.grd File chrome/app/theme/theme_resources.grd (right): https://codereview.chromium.org/1053323003/diff/20001/chrome/app/theme/theme_resources.grd#newcode828 chrome/app/theme/theme_resources.grd:828: <structure type="chrome_scaled_image" name="IDR_MEDIA_ROUTER_IDLE_ICON" file="common/media_router_idle.png" /> thank you for ...
5 years, 8 months ago (2015-04-07 16:53:39 UTC) #4
apacible
Thanks! https://codereview.chromium.org/1053323003/diff/20001/chrome/app/theme/theme_resources.grd File chrome/app/theme/theme_resources.grd (right): https://codereview.chromium.org/1053323003/diff/20001/chrome/app/theme/theme_resources.grd#newcode828 chrome/app/theme/theme_resources.grd:828: <structure type="chrome_scaled_image" name="IDR_MEDIA_ROUTER_IDLE_ICON" file="common/media_router_idle.png" /> On 2015/04/07 16:53:39, ...
5 years, 8 months ago (2015-04-07 16:56:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1053323003/20001
5 years, 8 months ago (2015-04-07 16:56:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 8 months ago (2015-04-07 17:59:05 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 17:59:47 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/08cef1e936221c0a33c8beef9c0843596e3de3dd
Cr-Commit-Position: refs/heads/master@{#324069}

Powered by Google App Engine
This is Rietveld 408576698