pkg/analyzer/lib/src/generated/resolver.dart - Issue 1053323002: Issue 22988. Improve checking for conflicts between parameters and local elements during extracting…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/generated/resolver.dart

Issue 1053323002: Issue 22988. Improve checking for conflicts between parameters and local elements during extracting… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analysis_server/test/services/refactoring/extract_method_test.dart ('K') | « pkg/analysis_server/test/services/refactoring/extract_method_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analyzer/lib/src/generated/resolver.dart

diff --git a/pkg/analyzer/lib/src/generated/resolver.dart b/pkg/analyzer/lib/src/generated/resolver.dart

index d7e71ada68e6f995754fdebacdd24f82530ec707..a0108827d7b9e825000cc10f25b35d9279dda4a8 100644

--- a/pkg/analyzer/lib/src/generated/resolver.dart

+++ b/pkg/analyzer/lib/src/generated/resolver.dart

@@ -3078,11 +3078,9 @@ class ElementBuilder extends RecursiveAstVisitor<Object> {

}

element = variable;

Block enclosingBlock = node.getAncestor((node) => node is Block);

- int functionEnd = node.offset + node.length;

- int blockEnd = enclosingBlock.offset + enclosingBlock.length;

// TODO(brianwilkerson) This isn't right for variables declared in a for

// loop.

- variable.setVisibleRange(functionEnd, blockEnd - functionEnd - 1);

+ variable.setVisibleRange(enclosingBlock.offset, enclosingBlock.length);

_currentHolder.addLocalVariable(variable);

variableName.staticElement = element;

} else {