Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issue 1053313002: Revert of Init Mojo embedder for Windows NaCl plugins. (Closed)

Created:
5 years, 8 months ago by teravest
Modified:
5 years, 8 months ago
CC:
chromium-reviews, dmichael (off chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Init Mojo embedder for Windows NaCl plugins. (patchset #6 id:160001 of https://codereview.chromium.org/1044953003/) Reason for revert: MojoFailsWithoutFlag fails on windows bots, as reported by sergeyu (weirdly, this passed in the CQ) Original issue's description: > Init Mojo embedder for Windows NaCl plugins. > > With this change (and another fix for NACL_BUILD_SUBARCH), we can test > Pepper/Mojo/NaCl support on Windows. > > This also moves embedder initialization to nacl_helper for clarity: > The Mojo embedder must be initialized in nacl_helper when that process > is used. When the plugin is running in a chrome process, ContentMain() > handles Mojo embedder initialization. > > BUG=414804 > R=dmichael@chromium.org, ncbray@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/75386dca6ebff785e62eb52472e660c757d5b2e8 TBR=ncbray@chromium.org,dmichael@chromium.org,sergeyu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=414804 Committed: https://crrev.com/78dffa27e6472ea500d73f9d7d695f7ecac0a5c5 Cr-Commit-Position: refs/heads/master@{#323793}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M chrome/test/ppapi/ppapi_browsertest.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M components/nacl.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl/loader/nacl_helper_linux.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M components/nacl/loader/nacl_helper_win_64.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M components/nacl/loader/nacl_listener.cc View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
teravest
Created Revert of Init Mojo embedder for Windows NaCl plugins.
5 years, 8 months ago (2015-04-03 19:25:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1053313002/1
5 years, 8 months ago (2015-04-03 19:25:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-03 19:26:31 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:40:00 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78dffa27e6472ea500d73f9d7d695f7ecac0a5c5
Cr-Commit-Position: refs/heads/master@{#323793}

Powered by Google App Engine
This is Rietveld 408576698