Action box menu

chrome/browser/ui/views/location_bar/action_box_button_view.h

Index: chrome/browser/ui/views/location_bar/action_box_button_view.h
diff --git a/chrome/browser/ui/views/location_bar/action_box_button_view.h b/chrome/browser/ui/views/location_bar/action_box_button_view.h
index fe36422fdf119391a09079cedab74460bd36a23f..e1df2f865ad3becbc18830f87a1468ebc4d26ed3 100644
--- a/chrome/browser/ui/views/location_bar/action_box_button_view.h
+++ b/chrome/browser/ui/views/location_bar/action_box_button_view.h
@@ -6,21 +6,26 @@
 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_ACTION_BOX_BUTTON_VIEW_H_
 #pragma once
 
+#include "chrome/browser/ui/views/location_bar/location_bar_view.h"
 #include "ui/views/controls/button/menu_button.h"
 #include "ui/views/controls/button/menu_button_listener.h"
 
-class ExtensionService;
+class ActionBoxMenu;
+class Profile;
 
 // ActionBoxButtonView displays a plus button with associated menu.
 class ActionBoxButtonView : public views::MenuButton,
                             public views::MenuButtonListener {
  public:
-  explicit ActionBoxButtonView(ExtensionService* extension_service);
+  explicit ActionBoxButtonView(Profile* profile,
+                               LocationBarView::Delegate* delegate);
   virtual ~ActionBoxButtonView();
 
   SkColor GetBackgroundColor();
   SkColor GetBorderColor();
 
+  void SetBookmarkState(bool on);
+
  private:
   // CustomButton
   virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
@@ -29,7 +34,13 @@ class ActionBoxButtonView : public views::MenuButton,
   virtual void OnMenuButtonClicked(View* source,
                                    const gfx::Point& point) OVERRIDE;
 
-  ExtensionService* extension_service_;
+  Profile* profile_;
+
+  LocationBarView::Delegate* delegate_;

[Aaron Boodman, 2012/07/02 22:41:34]

Weird to store another class' delegate. Seems like this is only being used to
get the Browser. Can you have LocationView pass in the browser instead?
LocationBar already has GetBrowserFromDelegate() that you can call.

[yefimt, 2012/07/11 22:34:34]

The problem is at the time of button creation GetBrowserFromDelegate() returns
NULL, because WebContents dont exist yet. So I need some way to call back to
LocationBarView at the time when button is pressed.

On 2012/07/02 22:41:34, Aaron Boodman wrote:

[Aaron Boodman, 2012/07/13 01:53:07]

In that case, define a delegate for ActionBoxButtonView that only has
GetBrowser(), and have LocationBar implement it.

It's more typing, but better layering/encapsulation.

On 2012/07/11 22:34:34, yefimt wrote:

[yefimt, 2012/07/13 19:59:20]

Done.

+
+  scoped_ptr<ActionBoxMenu> action_box_menu_;
+
+  bool bookmark_state_;
 
   DISALLOW_COPY_AND_ASSIGN(ActionBoxButtonView);
 };