chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc - Issue 1053303003: [MacViews] Implement colored window frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc

Issue 1053303003: [MacViews] Implement colored window frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compile on Aura. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/apps/app_window_native_widget_mac.h ('K') | « chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.h ('k') | chrome/browser/ui/views/apps/chrome_native_app_window_views_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc

diff --git a/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc b/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc

index c6540d00000d1baaf8e8acbd371698abd16b494e..9f08476f2e2277a138c58800bb553a9aef4d7a65 100644

--- a/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc

+++ b/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc

@@ -174,10 +174,10 @@ void ChromeNativeAppWindowViewsAura::OnBeforePanelWidgetInit(

}

-apps::AppWindowFrameView*

+views::NonClientFrameView*

ChromeNativeAppWindowViewsAura::CreateNonStandardAppFrame() {

- apps::AppWindowFrameView* frame =

- ChromeNativeAppWindowViews::CreateNonStandardAppFrame();

+ apps::AppWindowFrameView* frame = static_cast<apps::AppWindowFrameView*>(

tapted 2015/05/14 04:23:50 This isn't so nice.. What about making ChromeNativ

jackhou1 2015/05/14 06:20:40 Done.

+ ChromeNativeAppWindowViews::CreateNonStandardAppFrame());

// For Aura windows on the Ash desktop the sizes are different and the user

// can resize the window from slightly outside the bounds as well.