Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1053253003: Delete no longer needed pagesets, add new pagesets and make names more readable (Closed)

Created:
5 years, 8 months ago by rmistry
Modified:
5 years, 8 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Delete no longer needed pagesets, add new pagesets and make names more readable Deleted all pagesets mentioned in https://code.google.com/p/skia/issues/detail?id=3574#c18 Added new Wikipedia and Unicodetable pagesets from https://code.google.com/p/skia/issues/detail?id=3574#c19 BUG=skia:3574 NOTRY=true Committed: https://skia.googlesource.com/skia/+/80bd3ae9d76bcb9bdbf28c978c64134cdd503385

Patch Set 1 : Initial upload #

Patch Set 2 : Fix copyright year #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1556 lines) Patch
D tools/skp/page_sets/skia_amazon_desktop.py View 1 chunk +0 lines, -42 lines 0 comments Download
D tools/skp/page_sets/skia_androidpolice_nexus10.py View 1 chunk +0 lines, -43 lines 0 comments Download
D tools/skp/page_sets/skia_baidu_desktop.py View 1 chunk +0 lines, -42 lines 0 comments Download
D tools/skp/page_sets/skia_blogger_desktop.py View 1 chunk +0 lines, -42 lines 0 comments Download
D tools/skp/page_sets/skia_booking_desktop.py View 1 chunk +0 lines, -41 lines 0 comments Download
D tools/skp/page_sets/skia_cnet_nexus10.py View 1 chunk +0 lines, -41 lines 0 comments Download
D tools/skp/page_sets/skia_cnn_nexus10.py View 1 chunk +0 lines, -41 lines 0 comments Download
D tools/skp/page_sets/skia_culturalsolutions_nexus10.py View 1 chunk +0 lines, -44 lines 0 comments Download
D tools/skp/page_sets/skia_deviantart_nexus10.py View 1 chunk +0 lines, -41 lines 0 comments Download
D tools/skp/page_sets/skia_ebay_desktop.py View 1 chunk +0 lines, -43 lines 0 comments Download
D tools/skp/page_sets/skia_engadget_nexus10.py View 1 chunk +0 lines, -41 lines 0 comments Download
D tools/skp/page_sets/skia_facebook_desktop.py View 1 chunk +0 lines, -46 lines 0 comments Download
D tools/skp/page_sets/skia_fontwipe_desktop.py View 1 chunk +0 lines, -41 lines 0 comments Download
D tools/skp/page_sets/skia_forecastio_desktop.py View 1 chunk +0 lines, -41 lines 0 comments Download
D tools/skp/page_sets/skia_googleblog_nexus10.py View 1 chunk +0 lines, -41 lines 0 comments Download
D tools/skp/page_sets/skia_googlecalendar_nexus10.py View 1 chunk +0 lines, -42 lines 0 comments Download
D tools/skp/page_sets/skia_googleplus_desktop.py View 1 chunk +0 lines, -41 lines 0 comments Download
D tools/skp/page_sets/skia_gspro_nexus10.py View 1 chunk +0 lines, -41 lines 0 comments Download
D tools/skp/page_sets/skia_gws_desktop.py View 1 chunk +0 lines, -44 lines 0 comments Download
D tools/skp/page_sets/skia_hsfi_nexus10.py View 1 chunk +0 lines, -41 lines 0 comments Download
D tools/skp/page_sets/skia_jsfiddlehumperclip_desktop.py View 1 chunk +0 lines, -44 lines 0 comments Download
D tools/skp/page_sets/skia_linkedin_desktop.py View 1 chunk +0 lines, -41 lines 0 comments Download
D tools/skp/page_sets/skia_mlb_nexus10.py View 1 chunk +0 lines, -41 lines 0 comments Download
D tools/skp/page_sets/skia_mobilenews_desktop.py View 1 chunk +0 lines, -41 lines 0 comments Download
D tools/skp/page_sets/skia_nofolo_nexus10.py View 1 chunk +0 lines, -41 lines 0 comments Download
D tools/skp/page_sets/skia_pinterest_desktop.py View 1 chunk +0 lines, -41 lines 0 comments Download
D tools/skp/page_sets/skia_sahadan_nexus10.py View 1 chunk +0 lines, -41 lines 0 comments Download
D tools/skp/page_sets/skia_sfgate_desktop.py View 1 chunk +0 lines, -41 lines 0 comments Download
D tools/skp/page_sets/skia_silkfinance_desktop.py View 1 chunk +0 lines, -41 lines 0 comments Download
D tools/skp/page_sets/skia_slashdot_nexus10.py View 1 chunk +0 lines, -41 lines 0 comments Download
D tools/skp/page_sets/skia_techmeme_nexus10.py View 1 chunk +0 lines, -41 lines 0 comments Download
D tools/skp/page_sets/skia_twitter_desktop.py View 1 chunk +0 lines, -41 lines 0 comments Download
D tools/skp/page_sets/skia_ukwsj_nexus10.py View 1 chunk +0 lines, -41 lines 0 comments Download
A + tools/skp/page_sets/skia_unicodetable_desktop.py View 1 2 chunks +9 lines, -8 lines 2 comments Download
D tools/skp/page_sets/skia_weather_desktop.py View 1 chunk +0 lines, -41 lines 0 comments Download
A + tools/skp/page_sets/skia_wikipedia_desktop.py View 1 2 chunks +7 lines, -7 lines 0 comments Download
D tools/skp/page_sets/skia_wordpress_desktop.py View 1 chunk +0 lines, -42 lines 0 comments Download
D tools/skp/page_sets/skia_yahooanswers_desktop.py View 1 chunk +0 lines, -41 lines 0 comments Download
D tools/skp/page_sets/skia_youtube_desktop.py View 1 chunk +0 lines, -41 lines 0 comments Download
M tools/skp/webpages_playback.py View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
rmistry
5 years, 8 months ago (2015-04-03 15:11:12 UTC) #2
borenet
LGTM https://codereview.chromium.org/1053253003/diff/20001/tools/skp/page_sets/skia_unicodetable_desktop.py File tools/skp/page_sets/skia_unicodetable_desktop.py (right): https://codereview.chromium.org/1053253003/diff/20001/tools/skp/page_sets/skia_unicodetable_desktop.py#newcode27 tools/skp/page_sets/skia_unicodetable_desktop.py:27: class SkiaUnicodetableDesktopPageSet(page_set_module.PageSet): Out of curiosity, why can't we ...
5 years, 8 months ago (2015-04-03 15:17:36 UTC) #3
rmistry
https://codereview.chromium.org/1053253003/diff/20001/tools/skp/page_sets/skia_unicodetable_desktop.py File tools/skp/page_sets/skia_unicodetable_desktop.py (right): https://codereview.chromium.org/1053253003/diff/20001/tools/skp/page_sets/skia_unicodetable_desktop.py#newcode27 tools/skp/page_sets/skia_unicodetable_desktop.py:27: class SkiaUnicodetableDesktopPageSet(page_set_module.PageSet): On 2015/04/03 15:17:36, borenet wrote: > Out ...
5 years, 8 months ago (2015-04-03 15:21:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1053253003/20001
5 years, 8 months ago (2015-04-03 15:22:13 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 15:22:56 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/80bd3ae9d76bcb9bdbf28c978c64134cdd503385

Powered by Google App Engine
This is Rietveld 408576698