Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 1053233003: Fix the OpenSSL implementation of ExportKeyingMaterial. (Closed)

Created:
5 years, 8 months ago by davidben
Modified:
5 years, 8 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the OpenSSL implementation of ExportKeyingMaterial. The empty context and not using a context are different. BUG=none Committed: https://crrev.com/866c3d4a7669272896391a35dd768aa6f685af42 Cr-Commit-Position: refs/heads/master@{#323958}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M net/socket/ssl_client_socket_openssl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/socket/ssl_client_socket_unittest.cc View 1 chunk +19 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
davidben
Not high priority: I just noticed it last night and it took 5 minutes. No ...
5 years, 8 months ago (2015-04-03 19:45:11 UTC) #2
Ryan Sleevi
LGTM. Took me a while to find in RFC 5705 where this was stated, so ...
5 years, 8 months ago (2015-04-06 03:53:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1053233003/1
5 years, 8 months ago (2015-04-06 21:04:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-06 21:56:57 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 21:57:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/866c3d4a7669272896391a35dd768aa6f685af42
Cr-Commit-Position: refs/heads/master@{#323958}

Powered by Google App Engine
This is Rietveld 408576698