Issue 1053203006: Web MIDI: style clean up

Issue 1053203006: Web MIDI: style clean up (Closed)

Created:
5 years, 8 months ago by Takashi Toyoshima

Modified:
5 years, 8 months ago

Reviewers:
Takashi Toyoshima (Google), yhirano

CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Web MIDI: style clean up This patch contains some style cleanups I found recently. Committed: https://crrev.com/7982e1eb63974c007d60591289d5d378b12a9861 Cr-Commit-Position: refs/heads/master@{#325392}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -6 lines)			Patch
M	media/midi/midi_manager_alsa.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	media/midi/midi_manager_mac.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	media/midi/midi_manager_win.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	media/midi/midi_port_info.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	media/midi/midi_scheduler.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (2 generated)

Takashi Toyoshima

I noticed that the MidiScheduler's constructor misses "explicit". Others are minor changes to be up ...

5 years, 8 months ago (2015-04-15 09:50:15 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1053203006/1

5 years, 8 months ago (2015-04-16 02:58:13 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-16 04:26:17 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/7982e1eb63974c007d60591289d5d378b12a9861
Cr-Commit-Position: refs/heads/master@{#325392}