Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ppapi/shared_impl/BUILD.gn

Issue 1053203003: Work on Windows GN component build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« gpu/command_buffer/common/BUILD.gn ('K') | « ppapi/proxy/BUILD.gn ('k') | ppapi/thunk/BUILD.gn » ('j') | ppapi/thunk/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/shared_impl/BUILD.gn
diff --git a/ppapi/shared_impl/BUILD.gn b/ppapi/shared_impl/BUILD.gn
index 59f4ec05ee333afbdc8a0d0c6e28fda7b0c5d791..64ae537f6c6d5ed212b6312fc358e7823f442cd5 100644
--- a/ppapi/shared_impl/BUILD.gn
+++ b/ppapi/shared_impl/BUILD.gn
@@ -156,7 +156,7 @@ component("shared_impl") {
defines = [
"PPAPI_SHARED_IMPLEMENTATION",
- # This target also implements some thunk functions.
+ # This target goes in the same library as thunk (in GYP they are the same).
"PPAPI_THUNK_IMPLEMENTATION",
]
« gpu/command_buffer/common/BUILD.gn ('K') | « ppapi/proxy/BUILD.gn ('k') | ppapi/thunk/BUILD.gn » ('j') | ppapi/thunk/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698