Work on Windows GN component build.

Work on Windows GN component build.

This makes ppapi_shared link. This required many changes to gpu to match the structure of GYP in both component and non-component modes.

BUG=470212
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Committed: https://crrev.com/b3c7880dc9e66ff449b23e2273b4f20abecba442
Cr-Commit-Position: refs/heads/master@{#323937}

[brettw, 2015-04-03 23:07:14]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[brettw, 2015-04-03 23:07:21]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-03 23:07:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1053203003/20001

[commit-bot: I haz the power, 2015-04-03 23:18:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-03 23:18:14]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[brettw, 2015-04-04 00:02:55]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-04 00:03:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1053203003/40001

[commit-bot: I haz the power, 2015-04-04 00:12:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-04 00:12:45]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[brettw, 2015-04-04 00:38:08]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-04 00:38:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1053203003/60001

[commit-bot: I haz the power, 2015-04-04 00:48:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-04 00:48:01]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[brettw, 2015-04-04 01:14:37]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-04 01:14:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1053203003/80001

[commit-bot: I haz the power, 2015-04-04 01:28:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-04 01:28:01]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[brettw, 2015-04-04 15:13:09]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-04 15:13:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1053203003/100001

[commit-bot: I haz the power, 2015-04-04 15:21:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-04 15:21:00]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[brettw, 2015-04-04 21:27:40]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-04 21:27:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1053203003/120001

[commit-bot: I haz the power, 2015-04-04 21:35:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-04 21:35:26]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Dirk Pranke, 2015-04-06 16:54:07]

this basically looks okay, but I have a few questions that could probably be
answered by slightly clearer comments.

https://codereview.chromium.org/1053203003/diff/120001/gpu/command_buffer/cli...
File gpu/command_buffer/client/BUILD.gn (right):

https://codereview.chromium.org/1053203003/diff/120001/gpu/command_buffer/cli...
gpu/command_buffer/client/BUILD.gn:7: # separate static libraries in
non-component build.
Maybe explain *why* we need to separate things like this?

https://codereview.chromium.org/1053203003/diff/120001/gpu/command_buffer/com...
File gpu/command_buffer/common/BUILD.gn (right):

https://codereview.chromium.org/1053203003/diff/120001/gpu/command_buffer/com...
gpu/command_buffer/common/BUILD.gn:7: # non-component build.
same comment?

https://codereview.chromium.org/1053203003/diff/120001/ppapi/thunk/BUILD.gn
File ppapi/thunk/BUILD.gn (right):

https://codereview.chromium.org/1053203003/diff/120001/ppapi/thunk/BUILD.gn#n...
ppapi/thunk/BUILD.gn:8: # via the shared_impl component.
what's the advantage to having this be a separate source_set if only one target
can include it? Do you need to keep it separate so that you can set
PPAPI_SHARED_IMPLEMENTATION on just these files?

[brettw, 2015-04-06 18:12:58]

PTAL.

[brettw, 2015-04-06 18:13:06]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-06 18:13:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1053203003/140001

[Dirk Pranke, 2015-04-06 18:14:20]

lgtm

[brettw, 2015-04-06 18:16:47]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2015-04-06 18:16:52]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-04-06 18:17:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1053203003/140001

[commit-bot: I haz the power, 2015-04-06 19:55:57]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-04-06 20:05:27]

Patchset 8 (id:??) landed as
https://crrev.com/b3c7880dc9e66ff449b23e2273b4f20abecba442
Cr-Commit-Position: refs/heads/master@{#323937}

[pkotwicz, 2015-04-06 20:34:37]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/1057993004/ by pkotwicz@chromium.org.

The reason for reverting is: Reverting the CL because I think that it broke the
GN compile on Linux - See
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/26255/s....