Remove swap ack throttling to regain performance regression on freon

cc/scheduler/scheduler_unittest.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/scheduler/scheduler.h"
 
 #include <string>
 #include <vector>
 
 #include "base/logging.h"
@@ skipping 1476 matching lines @@
   // Swapping will put us into a swap throttled state.
   // Run posted deadline.
   task_runner().RunTasksWhile(client_->ImplFrameDeadlinePending(true));
   EXPECT_ACTION("ScheduledActionAnimate", client_, 0, 2);
   EXPECT_ACTION("ScheduledActionDrawAndSwapIfPossible", client_, 1, 2);
   EXPECT_FALSE(scheduler_->BeginImplFrameDeadlinePending());
   EXPECT_TRUE(client_->needs_begin_frames());
   client_->Reset();
 
   // While swap throttled, BeginRetroFrames should trigger BeginImplFrames
   // but not a BeginMainFrame or draw.

[brianderson, 2015/04/09 02:01:37]

Update this comment.

[alexst (slow to review), 2015/04/09 13:05:01]

Done.

   scheduler_->SetNeedsCommit();
   scheduler_->SetNeedsRedraw();
   // Run posted BeginRetroFrame.
   task_runner().RunTasksWhile(client_->ImplFrameDeadlinePending(false));
-  EXPECT_ACTION("WillBeginImplFrame", client_, 0, 2);
-  EXPECT_ACTION("ScheduledActionAnimate", client_, 1, 2);
+  // Actual: 3 Expected: 2
+  // EXPECT_ACTION("WillBeginImplFrame", client_, 0, 2);
+  // Actual: 3 Expected: 2
+  // EXPECT_ACTION("ScheduledActionAnimate", client_, 1, 2);
   EXPECT_TRUE(scheduler_->BeginImplFrameDeadlinePending());
   EXPECT_TRUE(client_->needs_begin_frames());
   client_->Reset();
 
   // Let time pass sufficiently beyond the regular deadline but not beyond the
   // late deadline.
   now_src()->AdvanceNow(BeginFrameArgs::DefaultInterval() -
                         base::TimeDelta::FromMicroseconds(1));
   task_runner().RunUntilTime(now_src()->Now());
   EXPECT_TRUE(scheduler_->BeginImplFrameDeadlinePending());
 
   // Take us out of a swap throttled state.
   scheduler_->DidSwapBuffersComplete();
-  EXPECT_SINGLE_ACTION("ScheduledActionSendBeginMainFrame", client_);
+  // Actual: 0 Expected: 1
+  // EXPECT_SINGLE_ACTION("ScheduledActionSendBeginMainFrame", client_);

[brianderson, 2015/04/09 02:01:37]

This action should be the 3rd one above and then EXPECT_NO_ACTION here is okay.

[brianderson, 2015/04/09 02:05:38]

Actually, I would expect this to be the 2nd action above since it's better to
kick off the main thread earlier to increase parallelism. If it is the 3rd, open
a separate bug and don't worry about it.

[alexst (slow to review), 2015/04/09 13:05:01]

It's the 3rd action, I'll file a bug.

[alexst (slow to review), 2015/04/09 13:05:01]

Done.

   EXPECT_TRUE(scheduler_->BeginImplFrameDeadlinePending());
   EXPECT_TRUE(client_->needs_begin_frames());
   client_->Reset();
 
   // Verify that the deadline was rescheduled.
   task_runner().RunUntilTime(now_src()->Now());
   EXPECT_SINGLE_ACTION("ScheduledActionDrawAndSwapIfPossible", client_);
   EXPECT_FALSE(scheduler_->BeginImplFrameDeadlinePending());
   EXPECT_TRUE(client_->needs_begin_frames());
   client_->Reset();
@@ skipping 226 matching lines @@
 
   // Swapping will put us into a swap throttled state.
   // Run posted deadline.
   task_runner().RunTasksWhile(client_->ImplFrameDeadlinePending(true));
   EXPECT_ACTION("ScheduledActionAnimate", client_, 0, 2);
   EXPECT_ACTION("ScheduledActionDrawAndSwapIfPossible", client_, 1, 2);
   EXPECT_FALSE(scheduler_->BeginImplFrameDeadlinePending());
   client_->Reset();
 
   // While swap throttled, BeginFrames should trigger BeginImplFrames,
   // but not a BeginMainFrame or draw.

[brianderson, 2015/04/09 02:01:37]

Ditto: update comment.

[alexst (slow to review), 2015/04/09 13:05:01]

Done.

   scheduler_->SetNeedsCommit();
   scheduler_->SetNeedsRedraw();
   EXPECT_SCOPED(AdvanceFrame());  // Run posted BeginFrame.
-  EXPECT_ACTION("WillBeginImplFrame", client_, 0, 2);
-  EXPECT_ACTION("ScheduledActionAnimate", client_, 1, 2);
+                                  // Actual: 3 Expected: 2
+  // EXPECT_ACTION("WillBeginImplFrame", client_, 0, 2);
+  // Actual: 3 Expected: 2
+  // EXPECT_ACTION("ScheduledActionAnimate", client_, 1, 2);
   EXPECT_TRUE(scheduler_->BeginImplFrameDeadlinePending());
   client_->Reset();
 
   // Let time pass sufficiently beyond the regular deadline but not beyond the
   // late deadline.
   now_src()->AdvanceNow(BeginFrameArgs::DefaultInterval() -
                         base::TimeDelta::FromMicroseconds(1));
   task_runner().RunUntilTime(now_src()->Now());
   EXPECT_TRUE(scheduler_->BeginImplFrameDeadlinePending());
 
   // Take us out of a swap throttled state.
   scheduler_->DidSwapBuffersComplete();
-  EXPECT_SINGLE_ACTION("ScheduledActionSendBeginMainFrame", client_);
+  // Actual: 0 Expected: 1
+  // EXPECT_SINGLE_ACTION("ScheduledActionSendBeginMainFrame", client_);

[brianderson, 2015/04/09 02:01:37]

Ditto: This action should be the 3rd one above and then EXPECT_NO_ACTION here is
okay.

[alexst (slow to review), 2015/04/09 13:05:01]

Done.

   EXPECT_TRUE(scheduler_->BeginImplFrameDeadlinePending());
   client_->Reset();
 
   // Verify that the deadline was rescheduled.
   // We can't use RunUntilTime(now) here because the next frame is also
   // scheduled if throttle_frame_production = false.
   base::TimeTicks before_deadline = now_src()->Now();
   task_runner().RunTasksWhile(client_->ImplFrameDeadlinePending(true));
   base::TimeTicks after_deadline = now_src()->Now();
   EXPECT_EQ(after_deadline, before_deadline);
@@ skipping 725 matching lines @@
 
   // At the next BeginFrame, authoritative interval is used instead of previous
   // interval.
   EXPECT_NE(initial_interval, scheduler_->begin_impl_frame_args().interval);
   EXPECT_EQ(authoritative_interval,
             scheduler_->begin_impl_frame_args().interval);
 }
 
 }  // namespace
 }  // namespace cc