Collect type feedback on result of Math.[round|ceil|floor]

src/hydrogen.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/hydrogen.h"
 
 #include <sstream>
 
 #include "src/v8.h"
 
@@ skipping 8312 matching lines @@
 
 
 bool HOptimizedGraphBuilder::TryInlineBuiltinFunctionCall(Call* expr) {
   if (!expr->target()->shared()->HasBuiltinFunctionId()) return false;
   BuiltinFunctionId id = expr->target()->shared()->builtin_function_id();
   switch (id) {
     case kMathExp:
       if (!FLAG_fast_math) break;
       // Fall through if FLAG_fast_math.
     case kMathRound:
+    case kMathFloor:
+      // If round has seen minus zero, don't inline, since that assumes
+      // returned value is an integer, which -0 definitely is not.
+      if (expr->ShouldHandleMinusZeroResult()) {
+        break;
+      }
     case kMathFround:
-    case kMathFloor:
     case kMathAbs:
     case kMathSqrt:
     case kMathLog:
     case kMathClz32:
       if (expr->arguments()->length() == 1) {
         HValue* argument = Pop();
         Drop(2);  // Receiver and function.
         HInstruction* op = NewUncasted<HUnaryMathOperation>(argument, id);
         ast_context()->ReturnInstruction(op, expr->id());
         return true;
       }
       break;
+    case kMathCeil:
+      // If round/floor has seen minus zero, don't inline, since that assumes
+      // returned value is an integer, which -0 definitely is not.
+      if (expr->ShouldHandleMinusZeroResult()) {
+        break;
+      }
+      if (expr->arguments()->length() == 1) {
+        HValue* argument = Pop();
+        Drop(2);  // Receiver and function.
+        HValue* op = NULL;
+        {
+          NoObservableSideEffectsScope s(this);
+          HValue* neg_arg =
+              AddUncasted<HMul>(graph()->GetConstantMinus1(), argument);
+          op = AddUncasted<HUnaryMathOperation>(neg_arg, kMathFloor);
+        }
+        HInstruction* neg_op =
+            NewUncasted<HMul>(graph()->GetConstantMinus1(), op);
+        ast_context()->ReturnInstruction(neg_op, expr->id());
+        return true;
+      }
+      break;
     case kMathImul:
       if (expr->arguments()->length() == 2) {
         HValue* right = Pop();
         HValue* left = Pop();
         Drop(2);  // Receiver and function.
         HInstruction* op =
             HMul::NewImul(isolate(), zone(), context(), left, right);
         ast_context()->ReturnInstruction(op, expr->id());
         return true;
       }
@@ skipping 73 matching lines @@
         Drop(2);  // Receiver and function.
         HInstruction* result = NewUncasted<HStringCharFromCode>(argument);
         ast_context()->ReturnInstruction(result, expr->id());
         return true;
       }
       break;
     case kMathExp:
       if (!FLAG_fast_math) break;
       // Fall through if FLAG_fast_math.
     case kMathRound:
+    case kMathFloor:
+      // If round/floor has seen minus zero, don't inline, since that assumes
+      // returned value is an integer, which -0 definitely is not.
+      if (expr->ShouldHandleMinusZeroResult()) {
+        break;
+      }
     case kMathFround:
-    case kMathFloor:
     case kMathAbs:
     case kMathSqrt:
     case kMathLog:
     case kMathClz32:
       if (argument_count == 2) {
         HValue* argument = Pop();
         Drop(2);  // Receiver and function.
         HInstruction* op = NewUncasted<HUnaryMathOperation>(argument, id);
         ast_context()->ReturnInstruction(op, expr->id());
         return true;
       }
       break;
+    case kMathCeil:
+      // If round/floor has seen minus zero, don't inline, since that assumes
+      // returned value is an integer, which -0 definitely is not.
+      if (expr->ShouldHandleMinusZeroResult()) {
+        break;
+      }
+      if (argument_count == 2) {
+        HValue* argument = Pop();
+        Drop(2);  // Receiver and function.
+        HValue* op = NULL;
+        {
+          NoObservableSideEffectsScope s(this);
+          HValue* neg_arg =
+              AddUncasted<HMul>(graph()->GetConstantMinus1(), argument);
+          op = AddUncasted<HUnaryMathOperation>(neg_arg, kMathFloor);
+        }
+        HInstruction* neg_op =
+            NewUncasted<HMul>(graph()->GetConstantMinus1(), op);
+        ast_context()->ReturnInstruction(neg_op, expr->id());
+        return true;
+      }
+      break;
     case kMathPow:
       if (argument_count == 3) {
         HValue* right = Pop();
         HValue* left = Pop();
         Drop(2);  // Receiver and function.
         HInstruction* result = NULL;
         // Use sqrt() if exponent is 0.5 or -0.5.
         if (right->IsConstant() && HConstant::cast(right)->HasDoubleValue()) {
           double exponent = HConstant::cast(right)->DoubleValue();
           if (exponent == 0.5) {
@@ skipping 3715 matching lines @@
 
 void HOptimizedGraphBuilder::GenerateMathClz32(CallRuntime* call) {
   DCHECK(call->arguments()->length() == 1);
   CHECK_ALIVE(VisitForValue(call->arguments()->at(0)));
   HValue* value = Pop();
   HInstruction* result = NewUncasted<HUnaryMathOperation>(value, kMathClz32);
   return ast_context()->ReturnInstruction(result, call->id());
 }
 
 
-void HOptimizedGraphBuilder::GenerateMathFloor(CallRuntime* call) {
-  DCHECK(call->arguments()->length() == 1);
-  CHECK_ALIVE(VisitForValue(call->arguments()->at(0)));
-  HValue* value = Pop();
-  HInstruction* result = NewUncasted<HUnaryMathOperation>(value, kMathFloor);
-  return ast_context()->ReturnInstruction(result, call->id());
-}
-
-
 void HOptimizedGraphBuilder::GenerateMathLogRT(CallRuntime* call) {
   DCHECK(call->arguments()->length() == 1);
   CHECK_ALIVE(VisitForValue(call->arguments()->at(0)));
   HValue* value = Pop();
   HInstruction* result = NewUncasted<HUnaryMathOperation>(value, kMathLog);
   return ast_context()->ReturnInstruction(result, call->id());
 }
 
 
 void HOptimizedGraphBuilder::GenerateMathSqrt(CallRuntime* call) {
@@ skipping 898 matching lines @@
   if (ShouldProduceTraceOutput()) {
     isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
   }
 
 #ifdef DEBUG
   graph_->Verify(false);  // No full verify.
 #endif
 }
 
 } }  // namespace v8::internal