Collect type feedback on result of Math.[round|ceil|floor]

src/type-feedback-vector.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
+#include "src/code-stubs.h"
 #include "src/ic/ic.h"
 #include "src/ic/ic-state.h"
 #include "src/objects.h"
 #include "src/type-feedback-vector-inl.h"
 
 namespace v8 {
 namespace internal {
 
 // static
 TypeFeedbackVector::VectorICKind TypeFeedbackVector::FromCodeKind(
@@ skipping 288 matching lines @@
   }
 
   return UNINITIALIZED;
 }
 
 
 InlineCacheState CallICNexus::StateFromFeedback() const {
   Isolate* isolate = GetIsolate();
   Object* feedback = GetFeedback();
   DCHECK(!FLAG_vector_ics ||
-         GetFeedbackExtra() == *vector()->UninitializedSentinel(isolate));
+         GetFeedbackExtra() == *vector()->UninitializedSentinel(isolate) ||
+         GetFeedbackExtra() ==
+             Smi::FromInt(CallICStub::kHasReturnedMinusZeroSentinel));

[mvstanton, 2015/05/04 09:41:22]

I like this tight control of expectations, thx!

[danno, 2015/05/04 14:31:56]

Acknowledged.

 
   if (feedback == *vector()->MegamorphicSentinel(isolate)) {
     return GENERIC;
   } else if (feedback->IsAllocationSite() || feedback->IsWeakCell()) {
     return MONOMORPHIC;
   }
 
   CHECK(feedback == *vector()->UninitializedSentinel(isolate));
   return UNINITIALIZED;
 }
@@ skipping 10 matching lines @@
 void CallICNexus::ConfigureMonomorphicArray() {
   Object* feedback = GetFeedback();
   if (!feedback->IsAllocationSite()) {
     Handle<AllocationSite> new_site =
         GetIsolate()->factory()->NewAllocationSite();
     SetFeedback(*new_site);
   }
 }
 
 
+void CallICNexus::ConfigureMonomorphicMathFunction(
+    Handle<JSFunction> function) {
+  Handle<WeakCell> new_cell = GetIsolate()->factory()->NewWeakCell(function);
+  SetFeedback(*new_cell);
+  SetFeedbackExtra(*vector()->UninitializedSentinel(GetIsolate()));
+}
+
+
 void CallICNexus::ConfigureUninitialized() {
   SetFeedback(*vector()->UninitializedSentinel(GetIsolate()),
               SKIP_WRITE_BARRIER);
 }
 
 
 void CallICNexus::ConfigureMonomorphic(Handle<JSFunction> function) {
   Handle<WeakCell> new_cell = GetIsolate()->factory()->NewWeakCell(function);
   SetFeedback(*new_cell);
 }
@@ skipping 198 matching lines @@
 
 Name* KeyedLoadICNexus::FindFirstName() const {
   Object* feedback = GetFeedback();
   if (feedback->IsString()) {
     return Name::cast(feedback);
   }
   return NULL;
 }
 }
 }  // namespace v8::internal