ui/views/controls/textfield/textfield.cc - Issue 1053143002: Make View::Paint use ui::PaintRecorder to access PaintContext's canvas

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/textfield/textfield.cc

Issue 1053143002: Make View::Paint use ui::PaintRecorder to access PaintContext's canvas (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: paintrecorder: . Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/textfield/textfield.cc

diff --git a/ui/views/controls/textfield/textfield.cc b/ui/views/controls/textfield/textfield.cc

index fee3378a8fbb5d44370487d9749da99127f10c02..8fce3257fb0473455c8e8eba9476793e32adb4c3 100644

--- a/ui/views/controls/textfield/textfield.cc

+++ b/ui/views/controls/textfield/textfield.cc

@@ -14,6 +14,7 @@

#include "ui/base/dragdrop/drag_utils.h"

#include "ui/base/touch/selection_bound.h"

#include "ui/base/ui_base_switches_util.h"

+#include "ui/compositor/paint_context.h"

#include "ui/compositor/scoped_animation_duration_scale_mode.h"

#include "ui/events/event.h"

#include "ui/events/keycodes/keyboard_codes.h"

@@ -1070,7 +1071,7 @@ void Textfield::WriteDragDataForView(View* sender,

// Desktop Linux Aura does not yet support transparency in drag images.

canvas->DrawColor(GetBackgroundColor());

#endif

- label.Paint(PaintContext(canvas.get()));

+ label.Paint(ui::PaintContext(canvas.get()));

const gfx::Vector2d kOffset(-15, 0);

drag_utils::SetDragImageOnDataObject(*canvas, kOffset, data);

if (controller_)

« ui/compositor/paint_recorder.h ('K') | « ui/views/controls/native/native_view_host_aura.cc ('k') | ui/views/view.h » ('j') | ui/views/view.cc » ('J')