chrome/browser/ui/views/toolbar/toolbar_action_view.cc - Issue 1053143002: Make View::Paint use ui::PaintRecorder to access PaintContext's canvas

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_action_view.cc

Issue 1053143002: Make View::Paint use ui::PaintRecorder to access PaintContext's canvas (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: paintrecorder: . Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/toolbar/toolbar_action_view.h ('k') | content/browser/renderer_host/render_widget_host_view_aura.h » ('j') | ui/compositor/paint_recorder.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/toolbar/toolbar_action_view.cc

diff --git a/chrome/browser/ui/views/toolbar/toolbar_action_view.cc b/chrome/browser/ui/views/toolbar/toolbar_action_view.cc

index 1e19e5e3cc77036dbb8a141731893f58b4cd019f..522d4f640b5dc555f85de475739b011e97a08659 100644

--- a/chrome/browser/ui/views/toolbar/toolbar_action_view.cc

+++ b/chrome/browser/ui/views/toolbar/toolbar_action_view.cc

@@ -19,6 +19,7 @@

#include "grit/theme_resources.h"

#include "ui/accessibility/ax_view_state.h"

#include "ui/base/resource/resource_bundle.h"

+#include "ui/compositor/paint_context.h"

#include "ui/events/event.h"

#include "ui/gfx/image/image_skia.h"

#include "ui/gfx/image/image_skia_operations.h"

@@ -107,7 +108,7 @@ void ToolbarActionView::ViewHierarchyChanged(

MenuButton::ViewHierarchyChanged(details);

}

-void ToolbarActionView::PaintChildren(const PaintContext& context) {

+void ToolbarActionView::PaintChildren(const ui::PaintContext& context) {

View::PaintChildren(context);

view_controller_->PaintExtra(context.canvas(), GetLocalBounds(),

GetCurrentWebContents());