chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc - Issue 1053143002: Make View::Paint use ui::PaintRecorder to access PaintContext's canvas

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc

Issue 1053143002: Make View::Paint use ui::PaintRecorder to access PaintContext's canvas (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: paintrecorder: . Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h ('k') | chrome/browser/ui/views/profiles/profile_chooser_view.cc » ('j') | ui/compositor/paint_recorder.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc

diff --git a/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc b/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc

index 3fe867e227184fb7353543f1437d20a1b4876a2b..7d092de0e900328016fb6d33ab3ad0a53b14f841 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc

+++ b/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc

@@ -12,6 +12,7 @@

#include "chrome/browser/ui/views/location_bar/location_bar_view.h"

#include "chrome/browser/ui/views/omnibox/omnibox_result_view.h"

#include "ui/base/theme_provider.h"

+#include "ui/compositor/paint_context.h"

#include "ui/gfx/canvas.h"

#include "ui/gfx/image/image.h"

#include "ui/gfx/path.h"

@@ -414,7 +415,7 @@ void OmniboxPopupContentsView::OnPaint(gfx::Canvas* canvas) {

width(), bottom_shadow_->height());

}

-void OmniboxPopupContentsView::PaintChildren(const PaintContext& context) {

+void OmniboxPopupContentsView::PaintChildren(const ui::PaintContext& context) {

gfx::Rect contents_bounds = GetContentsBounds();

contents_bounds.Inset(0, views::NonClientFrameView::kClientEdgeThickness, 0,

bottom_shadow_->height() - kBorderInterior);