chrome/browser/ui/views/location_bar/location_bar_view.cc - Issue 1053143002: Make View::Paint use ui::PaintRecorder to access PaintContext's canvas

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_view.cc

Issue 1053143002: Make View::Paint use ui::PaintRecorder to access PaintContext's canvas (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: paintrecorder: . Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/location_bar/location_bar_view.h ('k') | chrome/browser/ui/views/location_bar/page_action_image_view.h » ('j') | ui/compositor/paint_recorder.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/location_bar_view.cc

diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.cc b/chrome/browser/ui/views/location_bar/location_bar_view.cc

index 8c0cc94409b52a35d711baebc9192fead2f6bac9..518050f7c4c0603c9e3ee425c688e48986ceb5c4 100644

--- a/chrome/browser/ui/views/location_bar/location_bar_view.cc

+++ b/chrome/browser/ui/views/location_bar/location_bar_view.cc

@@ -74,6 +74,7 @@

#include "ui/base/l10n/l10n_util.h"

#include "ui/base/resource/resource_bundle.h"

#include "ui/base/theme_provider.h"

+#include "ui/compositor/paint_context.h"

#include "ui/events/event.h"

#include "ui/gfx/animation/slide_animation.h"

#include "ui/gfx/canvas.h"

@@ -1217,7 +1218,7 @@ void LocationBarView::OnPaint(gfx::Canvas* canvas) {

// inner shadow which should be drawn over the contents.

}

-void LocationBarView::PaintChildren(const PaintContext& context) {

+void LocationBarView::PaintChildren(const ui::PaintContext& context) {

// Paint all the children except for the omnibox itself, which may need to be

// clipped if it's animating in.

for (int i = 0, count = child_count(); i < count; ++i) {