Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 1053123010: base: Remove using declaration from test_suite.h header. (Closed)

Created:
5 years, 8 months ago by tfarina
Modified:
5 years, 8 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, brettw, tkent
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: Remove using declaration from test_suite.h header. WebKit has been fixed in https://src.chromium.org/viewvc/blink?revision=193998&view=revision BUG=None TEST=trybots R=thestig@chromium.org TBR=sergeyu@chromium.org,cpu@chromium.org Committed: https://crrev.com/9cfdfc07ef3042e059d5a51a91cbe4f13cfca341 Cr-Commit-Position: refs/heads/master@{#327147}

Patch Set 1 #

Patch Set 2 : base namespace #

Patch Set 3 : clobber and win fixes #

Patch Set 4 : chrome/installer fix #

Patch Set 5 : chrome/installer/setup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -46 lines) Patch
M base/test/test_suite.h View 1 chunk +0 lines, -4 lines 0 comments Download
M base/test/test_suite.cc View 1 13 chunks +34 lines, -36 lines 0 comments Download
M chrome/installer/setup/run_all_unittests.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/run_all_unittests.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M remoting/test/app_remoting_test_driver.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/tests/integration_tests/integration_tests.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/tests/unit_tests/unit_tests.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/tests/validation_tests/unit_tests.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
tfarina
5 years, 8 months ago (2015-04-25 19:17:18 UTC) #1
Lei Zhang
lgtm, but you'll need more OWNERS for remoting/ and sandbox/
5 years, 8 months ago (2015-04-27 20:21:09 UTC) #2
tfarina
TBRing Sergey for remoting/ and Carlos for sandbox/win/.
5 years, 8 months ago (2015-04-27 21:23:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1053123010/80001
5 years, 8 months ago (2015-04-27 21:25:54 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 8 months ago (2015-04-27 21:50:59 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 21:52:39 UTC) #8
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/9cfdfc07ef3042e059d5a51a91cbe4f13cfca341
Cr-Commit-Position: refs/heads/master@{#327147}

Powered by Google App Engine
This is Rietveld 408576698