Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2512)

Unified Diff: Source/web/TextFinder.cpp

Issue 1053123007: Invalidate paint of tickmarks on document change (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/FrameView.cpp ('k') | Source/web/WebLocalFrameImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/TextFinder.cpp
diff --git a/Source/web/TextFinder.cpp b/Source/web/TextFinder.cpp
index d699197d69d088b04bde8bbca0a238e657ea24b5..d9a04fe45b7a5b0733bf7c96be0716f34b7cdd12 100644
--- a/Source/web/TextFinder.cpp
+++ b/Source/web/TextFinder.cpp
@@ -151,7 +151,7 @@ bool TextFinder::find(int identifier, const WebString& searchText, const WebFind
if (!options.findNext)
clearFindMatchesCache();
- ownerFrame().invalidateAll();
+ ownerFrame().frameView()->invalidatePaintForTickmarks();
return false;
}
@@ -206,8 +206,8 @@ void TextFinder::stopFindingAndClearSelection()
ownerFrame().frame()->editor().setMarkedTextMatchesAreHighlighted(false);
clearFindMatchesCache();
- // Let the frame know that we don't want tickmarks or highlighting anymore.
- ownerFrame().invalidateAll();
+ // Let the frame know that we don't want tickmarks anymore.
+ ownerFrame().frameView()->invalidatePaintForTickmarks();
}
void TextFinder::reportFindInPageResultToAccessibility(int identifier)
@@ -411,7 +411,7 @@ void TextFinder::finishCurrentScopingEffort(int identifier)
m_lastFindRequestCompletedWithNoMatches = !m_lastMatchCount;
// This frame is done, so show any scrollbar tickmarks we haven't drawn yet.
- ownerFrame().invalidateScrollbar();
+ ownerFrame().frameView()->invalidatePaintForTickmarks();
}
void TextFinder::cancelPendingScopingEffort()
@@ -744,7 +744,7 @@ void TextFinder::invalidateIfNecessary()
if (m_lastMatchCount <= m_nextInvalidateAfter)
return;
- // FIXME: (http://b/1088165) Optimize the drawing of the tickmarks and
+ // FIXME: (http://crbug.com/6819) Optimize the drawing of the tickmarks and
// remove this. This calculation sets a milestone for when next to
// invalidate the scrollbar and the content area. We do this so that we
// don't spend too much time drawing the scrollbar over and over again.
@@ -756,7 +756,7 @@ void TextFinder::invalidateIfNecessary()
int i = m_lastMatchCount / startSlowingDownAfter;
m_nextInvalidateAfter += i * slowdown;
- ownerFrame().invalidateScrollbar();
+ ownerFrame().frameView()->invalidatePaintForTickmarks();
}
void TextFinder::flushCurrentScoping()
« no previous file with comments | « Source/core/frame/FrameView.cpp ('k') | Source/web/WebLocalFrameImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698