Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: Source/web/TextFinder.cpp

Issue 1053123007: Invalidate paint of tickmarks on document change (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/TextFinder.cpp
diff --git a/Source/web/TextFinder.cpp b/Source/web/TextFinder.cpp
index d699197d69d088b04bde8bbca0a238e657ea24b5..394d37c9a30d61f03442db3b4f2c8fb01629666b 100644
--- a/Source/web/TextFinder.cpp
+++ b/Source/web/TextFinder.cpp
@@ -151,7 +151,7 @@ bool TextFinder::find(int identifier, const WebString& searchText, const WebFind
if (!options.findNext)
clearFindMatchesCache();
- ownerFrame().invalidateAll();
Xianzhu 2015/04/17 18:25:03 We don't need to invalidate all. DocumentMarkerCon
+ ownerFrame().frameView()->invalidatePaintOfTickmarks();
chrishtr 2015/04/17 23:21:42 Why special code here just for tickmarks?
Xianzhu 2015/04/18 02:13:48 DocumentMarkerController invalidates the layoutObj
return false;
}
@@ -207,7 +207,7 @@ void TextFinder::stopFindingAndClearSelection()
clearFindMatchesCache();
// Let the frame know that we don't want tickmarks or highlighting anymore.
- ownerFrame().invalidateAll();
+ ownerFrame().frameView()->invalidatePaintOfTickmarks();
}
void TextFinder::reportFindInPageResultToAccessibility(int identifier)
@@ -411,7 +411,7 @@ void TextFinder::finishCurrentScopingEffort(int identifier)
m_lastFindRequestCompletedWithNoMatches = !m_lastMatchCount;
// This frame is done, so show any scrollbar tickmarks we haven't drawn yet.
- ownerFrame().invalidateScrollbar();
+ ownerFrame().frameView()->invalidatePaintOfTickmarks();
}
void TextFinder::cancelPendingScopingEffort()
@@ -756,7 +756,7 @@ void TextFinder::invalidateIfNecessary()
int i = m_lastMatchCount / startSlowingDownAfter;
m_nextInvalidateAfter += i * slowdown;
- ownerFrame().invalidateScrollbar();
+ ownerFrame().frameView()->invalidatePaintOfTickmarks();
}
void TextFinder::flushCurrentScoping()

Powered by Google App Engine
This is Rietveld 408576698